From 974d4d9739e43e537f679e9a11f6a8ef5c70fe16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Fri, 8 Dec 2017 11:53:51 +0100 Subject: [PATCH] Revert "Don't animate panels on initial render (#10130)" This reverts commit e0c173c5afd3a353fda6fc2fdca396438a5e71b6. --- .../dashboard/dashgrid/DashboardGrid.tsx | 76 +++++++------------ public/sass/components/_dashboard_grid.scss | 9 --- 2 files changed, 27 insertions(+), 58 deletions(-) diff --git a/public/app/features/dashboard/dashgrid/DashboardGrid.tsx b/public/app/features/dashboard/dashgrid/DashboardGrid.tsx index 392d8f4e805..bb06df15183 100644 --- a/public/app/features/dashboard/dashgrid/DashboardGrid.tsx +++ b/public/app/features/dashboard/dashgrid/DashboardGrid.tsx @@ -11,59 +11,37 @@ import sizeMe from 'react-sizeme'; let lastGridWidth = 1200; -export interface GridWrapperProps { - size: any; - layout: any; - children: any; - onResize: any; - onResizeStop: any; - onWidthChange: any; - onLayoutChange: any; -} - -class GridWrapper extends React.Component { - animated: boolean; - - constructor(props) { - super(props); - if (this.props.size.width === 0) { - console.log('size is zero!'); - } - - const width = this.props.size.width > 0 ? this.props.size.width : lastGridWidth; - if (width !== lastGridWidth) { - this.props.onWidthChange(); - lastGridWidth = width; - } +function GridWrapper({size, layout, onLayoutChange, children, onResize, onResizeStop, onWidthChange}) { + if (size.width === 0) { + console.log('size is zero!'); } - componentDidMount() { - // Disable animation on initial rendering and enable it when component has been mounted. - this.animated = true; + const width = size.width > 0 ? size.width : lastGridWidth; + if (width !== lastGridWidth) { + onWidthChange(); + lastGridWidth = width; } - render() { - return ( - - {this.props.children} - - ); - } + return ( + + {children} + + ); } const SizedReactLayoutGrid = sizeMe({monitorWidth: true})(GridWrapper); diff --git a/public/sass/components/_dashboard_grid.scss b/public/sass/components/_dashboard_grid.scss index 656efe4c880..076e8cad0b7 100644 --- a/public/sass/components/_dashboard_grid.scss +++ b/public/sass/components/_dashboard_grid.scss @@ -53,12 +53,3 @@ .react-grid-item.react-draggable-dragging.panel { z-index: $zindex-dropdown; } - -// Disable animation on initial rendering and enable it when component has been mounted. -.react-grid-item.cssTransforms.panel { - transition-property: none; -} - -.animated .react-grid-item.cssTransforms.panel { - transition-property: transform; -}