From 98a6b5debf8a0e24162e96862f3232ba2f038450 Mon Sep 17 00:00:00 2001 From: Juan Cabanas Date: Wed, 20 Mar 2024 12:00:19 -0300 Subject: [PATCH] Scenes: Fix public dashboard email sharing section (#84467) --- .../ConfigPublicDashboard.tsx | 2 +- .../EmailSharingConfiguration.tsx | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx index 06b824a5e94..1655446ed2a 100644 --- a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx +++ b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx @@ -124,7 +124,7 @@ export function ConfigPublicDashboardBase({ )} - {hasEmailSharingEnabled && } + {hasEmailSharingEnabled && } { +export const EmailSharingConfiguration = ({ dashboard }: { dashboard: DashboardModel | DashboardScene }) => { const { width } = useWindowSize(); const styles = useStyles2(getStyles); - const dashboardState = useSelector((store) => store.dashboard); - const dashboard = dashboardState.getModel()!; - const { data: publicDashboard } = useGetPublicDashboardQuery(dashboard.uid); + const dashboardUid = dashboard instanceof DashboardScene ? dashboard.state.uid : dashboard.uid; + const { data: publicDashboard } = useGetPublicDashboardQuery(dashboardUid); const [updateShareType] = useUpdatePublicDashboardMutation(); const [addEmail, { isLoading: isAddEmailLoading }] = useAddRecipientMutation(); @@ -135,7 +136,7 @@ export const EmailSharingConfiguration = () => { const onSubmit = async (data: EmailSharingConfigurationForm) => { DashboardInteractions.publicDashboardEmailInviteClicked(); - await addEmail({ recipient: data.email, uid: publicDashboard!.uid, dashboardUid: dashboard.uid }).unwrap(); + await addEmail({ recipient: data.email, uid: publicDashboard!.uid, dashboardUid }).unwrap(); reset({ email: '', shareType: PublicDashboardShareType.EMAIL }); }; @@ -215,7 +216,7 @@ export const EmailSharingConfiguration = () => { {!!publicDashboard?.recipients?.length && ( )}