public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Table: Fix type safety (#52525)

Browse Source
This commit is contained in:
Dominik Prokop
2022-07-20 05:26:04 -07:00
committed by GitHub
parent 813f18b990
commit 98d41f0bf8
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/grafana-ui/src/components/Table/CellActions.tsx
+10 -4
View File
@@ -25,13 +25,19 @@ export function CellActions({ field, cell, previewMode, onCellFilterAdded }: Cel
}; };
const onFilterFor = useCallback( const onFilterFor = useCallback(
(event: React.MouseEvent<HTMLButtonElement>) => (event: React.MouseEvent<HTMLButtonElement>) => {
onCellFilterAdded({ key: field.name, operator: FILTER_FOR_OPERATOR, value: cell.value }), if (onCellFilterAdded) {
onCellFilterAdded({ key: field.name, operator: FILTER_FOR_OPERATOR, value: cell.value });
}
},
[cell, field, onCellFilterAdded] [cell, field, onCellFilterAdded]
); );
const onFilterOut = useCallback( const onFilterOut = useCallback(
(event: React.MouseEvent<HTMLButtonElement>) => (event: React.MouseEvent<HTMLButtonElement>) => {
onCellFilterAdded({ key: field.name, operator: FILTER_OUT_OPERATOR, value: cell.value }), if (onCellFilterAdded) {
onCellFilterAdded({ key: field.name, operator: FILTER_OUT_OPERATOR, value: cell.value });
}
},
[cell, field, onCellFilterAdded] [cell, field, onCellFilterAdded]
); );
packages/grafana-ui/src/components/Table/types.ts
+1 -1
View File
@@ -29,7 +29,7 @@ export interface TableCellProps extends CellProps<any> {
tableStyles: TableStyles; tableStyles: TableStyles;
cellProps: React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement>; cellProps: React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement>;
field: Field; field: Field;
onCellFilterAdded: TableFilterActionCallback; onCellFilterAdded?: TableFilterActionCallback;
innerWidth: number; innerWidth: number;
} }