From 9982830bd7937c7b81b7fd06a2f35af501e2c805 Mon Sep 17 00:00:00 2001
From: Dominik Prokop <dominik.prokop@grafana.com>
Date: Tue, 30 Jan 2024 01:28:17 -0800
Subject: [PATCH] DashboardScene: Do not hide variables on save (#81501)

---
 .../__snapshots__/transformSceneToSaveModel.test.ts.snap       | 2 --
 .../serialization/sceneVariablesSetToVariables.test.ts         | 1 -
 .../serialization/sceneVariablesSetToVariables.ts              | 3 ---
 3 files changed, 6 deletions(-)

diff --git a/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModel.test.ts.snap b/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModel.test.ts.snap
index ff85dd88d84..cd2f371a21a 100644
--- a/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModel.test.ts.snap
+++ b/public/app/features/dashboard-scene/serialization/__snapshots__/transformSceneToSaveModel.test.ts.snap
@@ -494,7 +494,6 @@ exports[`transformSceneToSaveModel Given a simple scene with custom settings Sho
           "text": "1m",
           "value": "1m",
         },
-        "hide": 2,
         "name": "intervalVar",
         "query": "1m,10m,30m,1h,6h,12h,1d,7d,14d,30d",
         "refresh": 2,
@@ -812,7 +811,6 @@ exports[`transformSceneToSaveModel Given a simple scene with variables Should tr
           "text": "1m",
           "value": "1m",
         },
-        "hide": 2,
         "name": "intervalVar",
         "query": "1m,10m,30m,1h,6h,12h,1d,7d,14d,30d",
         "refresh": 2,
diff --git a/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.test.ts b/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.test.ts
index 7dfab1318bf..112e75b419d 100644
--- a/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.test.ts
+++ b/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.test.ts
@@ -336,7 +336,6 @@ describe('sceneVariablesSetToVariables', () => {
         "value": "text value",
       },
       "description": "test-desc",
-      "hide": 2,
       "label": "test-label",
       "name": "test",
       "query": "text value",
diff --git a/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.ts b/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.ts
index 535541827cb..a2145c75777 100644
--- a/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.ts
+++ b/public/app/features/dashboard-scene/serialization/sceneVariablesSetToVariables.ts
@@ -34,7 +34,6 @@ export function sceneVariablesSetToVariables(set: SceneVariables) {
         includeAll: variable.state.includeAll,
         multi: variable.state.isMulti,
         skipUrlSync: variable.state.skipUrlSync,
-        hide: variable.state.hide || VariableHide.dontHide,
       });
     } else if (sceneUtils.isCustomVariable(variable)) {
       variables.push({
@@ -90,7 +89,6 @@ export function sceneVariablesSetToVariables(set: SceneVariables) {
           value: variable.state.value,
         },
         query: intervals,
-        hide: VariableHide.hideVariable,
         refresh: variable.state.refresh,
         // @ts-expect-error ?? how to fix this without adding the ts-expect-error
         auto: variable.state.autoEnabled,
@@ -105,7 +103,6 @@ export function sceneVariablesSetToVariables(set: SceneVariables) {
           value: variable.state.value,
         },
         query: variable.state.value,
-        hide: VariableHide.hideVariable,
       });
     } else {
       throw new Error('Unsupported variable type');