public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Chore: removing (more) redundant transactions (#89373)

Browse Source 
* remove redundant transactions from single-statement sql methods
This commit is contained in:
Kristin Laemmert
2024-06-25 09:19:49 -04:00
committed by GitHub
parent 66dc20f46f
commit 9a3477dd11
8 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/preference/prefimpl/xorm_store.go
+2 -2
View File
@@ -63,7 +63,7 @@ func (s *sqlStore) List(ctx context.Context, query *pref.Preference) ([]*pref.Pr
}
func (s *sqlStore) Update(ctx context.Context, cmd *pref.Preference) error {
return s.db.WithTransactionalDbSession(ctx, func(sess *db.Session) error {
return s.db.WithDbSession(ctx, func(sess *db.Session) error {
_, err := sess.ID(cmd.ID).AllCols().Update(cmd)
return err
})
@@ -72,7 +72,7 @@ func (s *sqlStore) Update(ctx context.Context, cmd *pref.Preference) error {
func (s *sqlStore) Insert(ctx context.Context, cmd *pref.Preference) (int64, error) {
var ID int64
var err error
err = s.db.WithTransactionalDbSession(ctx, func(sess *db.Session) error {
err = s.db.WithDbSession(ctx, func(sess *db.Session) error {
_, err = sess.Insert(cmd)
ID = cmd.ID
return err