Alerting/consistent api errors (#34858)

* consolidates alertmanager api errors

* util & testing consistent errors

* consistent errors for rest of ngalert apis

* updates expected errors in testware

* bump ci

* linting

* unrelated: dashboard.go lint

pkg/services/ngalert/api/api_ruler.go

@@ -2,7 +2,6 @@ package api
 
 import (
 	"errors"
-	"fmt"
 	"net/http"
 	"time"
 
@@ -38,7 +37,7 @@ func (srv RulerSrv) RouteDeleteNamespaceRulesConfig(c *models.ReqContext) respon
 
 	uids, err := srv.store.DeleteNamespaceAlertRules(c.SignedInUser.OrgId, namespace.Uid)
 	if err != nil {
-		return response.Error(http.StatusInternalServerError, "failed to delete namespace alert rules", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to delete namespace alert rules")
 	}
 
 	for _, uid := range uids {
@@ -59,9 +58,9 @@ func (srv RulerSrv) RouteDeleteRuleGroupConfig(c *models.ReqContext) response.Re
 
 	if err != nil {
 		if errors.Is(err, ngmodels.ErrRuleGroupNamespaceNotFound) {
-			return response.Error(http.StatusNotFound, "failed to delete rule group", err)
+			return ErrResp(http.StatusNotFound, err, "failed to delete rule group")
 		}
-		return response.Error(http.StatusInternalServerError, "failed to delete rule group", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to delete rule group")
 	}
 
 	for _, uid := range uids {
@@ -83,7 +82,7 @@ func (srv RulerSrv) RouteGetNamespaceRulesConfig(c *models.ReqContext) response.
 		NamespaceUID: namespace.Uid,
 	}
 	if err := srv.store.GetNamespaceAlertRules(&q); err != nil {
-		return response.Error(http.StatusInternalServerError, "failed to update rule group", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to update rule group")
 	}
 
 	result := apimodels.NamespaceConfigResponse{}
@@ -126,7 +125,7 @@ func (srv RulerSrv) RouteGetRulegGroupConfig(c *models.ReqContext) response.Resp
 		RuleGroup:    ruleGroup,
 	}
 	if err := srv.store.GetRuleGroupAlertRules(&q); err != nil {
-		return response.Error(http.StatusInternalServerError, "failed to get group alert rules", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to get group alert rules")
 	}
 
 	var ruleGroupInterval model.Duration
@@ -151,7 +150,7 @@ func (srv RulerSrv) RouteGetRulesConfig(c *models.ReqContext) response.Response
 		OrgID: c.SignedInUser.OrgId,
 	}
 	if err := srv.store.GetOrgAlertRules(&q); err != nil {
-		return response.Error(http.StatusInternalServerError, "failed to get alert rules", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to get alert rules")
 	}
 
 	configs := make(map[string]map[string]apimodels.GettableRuleGroupConfig)
@@ -217,17 +216,17 @@ func (srv RulerSrv) RoutePostNameRulesConfig(c *models.ReqContext, ruleGroupConf
 	// and rollback the transaction in case of violation
 	limitReached, err := srv.QuotaService.QuotaReached(c, "alert_rule")
 	if err != nil {
-		return response.Error(http.StatusInternalServerError, "failed to get quota", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to get quota")
 	}
 	if limitReached {
-		return response.Error(http.StatusForbidden, "quota reached", nil)
+		return ErrResp(http.StatusForbidden, errors.New("quota reached"), "")
 	}
 
 	// TODO validate UID uniqueness in the payload
 
 	//TODO: Should this belong in alerting-api?
 	if ruleGroupConfig.Name == "" {
-		return response.Error(http.StatusBadRequest, "rule group name is not valid", nil)
+		return ErrResp(http.StatusBadRequest, errors.New("rule group name is not valid"), "")
 	}
 
 	var alertRuleUIDs []string
@@ -238,7 +237,7 @@ func (srv RulerSrv) RoutePostNameRulesConfig(c *models.ReqContext, ruleGroupConf
 			Data:      r.GrafanaManagedAlert.Data,
 		}
 		if err := validateCondition(cond, c.SignedInUser, c.SkipCache, srv.DatasourceCache); err != nil {
-			return response.Error(http.StatusBadRequest, fmt.Sprintf("failed to validate alert rule %s", r.GrafanaManagedAlert.Title), err)
+			return ErrResp(http.StatusBadRequest, err, "failed to validate alert rule %s", r.GrafanaManagedAlert.Title)
 		}
 		alertRuleUIDs = append(alertRuleUIDs, r.GrafanaManagedAlert.UID)
 	}
@@ -249,11 +248,11 @@ func (srv RulerSrv) RoutePostNameRulesConfig(c *models.ReqContext, ruleGroupConf
 		RuleGroupConfig: ruleGroupConfig,
 	}); err != nil {
 		if errors.Is(err, ngmodels.ErrAlertRuleNotFound) {
-			return response.Error(http.StatusNotFound, "failed to update rule group", err)
+			return ErrResp(http.StatusNotFound, err, "failed to update rule group")
 		} else if errors.Is(err, ngmodels.ErrAlertRuleFailedValidation) {
-			return response.Error(http.StatusBadRequest, "failed to update rule group", err)
+			return ErrResp(http.StatusBadRequest, err, "failed to update rule group")
 		}
-		return response.Error(http.StatusInternalServerError, "failed to update rule group", err)
+		return ErrResp(http.StatusInternalServerError, err, "failed to update rule group")
 	}
 
 	for _, uid := range alertRuleUIDs {
@@ -292,10 +291,10 @@ func toGettableExtendedRuleNode(r ngmodels.AlertRule, namespaceID int64) apimode
 
 func toNamespaceErrorResponse(err error) response.Response {
 	if errors.Is(err, ngmodels.ErrCannotEditNamespace) {
-		return response.Error(http.StatusForbidden, err.Error(), err)
+		return ErrResp(http.StatusForbidden, err, err.Error())
 	}
 	if errors.Is(err, models.ErrDashboardIdentifierNotSet) {
-		return response.Error(http.StatusBadRequest, err.Error(), err)
+		return ErrResp(http.StatusBadRequest, err, err.Error())
 	}
 	return coreapi.ToFolderErrorResponse(err)
 }