From 9afbd1987497977470a1ba9d88018ebe0da308ba Mon Sep 17 00:00:00 2001 From: "grafana-delivery-bot[bot]" <132647405+grafana-delivery-bot[bot]@users.noreply.github.com> Date: Wed, 27 Mar 2024 03:28:15 +0700 Subject: [PATCH] [v11.0.x] Table Panel: Fix issue causing incorrect background coloring (#85214) Table Panel: Fix issue causing incorrect background coloring (#85121) Fix color bug (cherry picked from commit c9f9e94a6c4e8fcff9bddfa164fd2456cd898de9) Co-authored-by: Kyle Cunningham --- packages/grafana-data/src/themes/createVisualizationColors.ts | 2 +- packages/grafana-ui/src/components/Table/utils.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/grafana-data/src/themes/createVisualizationColors.ts b/packages/grafana-data/src/themes/createVisualizationColors.ts index 163e6ba7c2b..89ccd9bbd20 100644 --- a/packages/grafana-data/src/themes/createVisualizationColors.ts +++ b/packages/grafana-data/src/themes/createVisualizationColors.ts @@ -52,7 +52,7 @@ export function createVisualizationColors(colors: ThemeColors): ThemeVisualizati } // special colors - byNameIndex['transparent'] = 'rgba(0,0,0,0)'; + byNameIndex['transparent'] = colors.mode === 'light' ? 'rgba(255, 255, 255, 0)' : 'rgba(0,0,0,0)'; byNameIndex['panel-bg'] = colors.background.primary; byNameIndex['text'] = colors.text.primary; diff --git a/packages/grafana-ui/src/components/Table/utils.ts b/packages/grafana-ui/src/components/Table/utils.ts index 1274dc053d2..5605e3c6175 100644 --- a/packages/grafana-ui/src/components/Table/utils.ts +++ b/packages/grafana-ui/src/components/Table/utils.ts @@ -617,7 +617,7 @@ export function getCellColors( if (mode === TableCellBackgroundDisplayMode.Basic) { textColor = getTextColorForAlphaBackground(displayValue.color!, tableStyles.theme.isDark); - bgColor = tinycolor(displayValue.color).setAlpha(1).toRgbString(); + bgColor = tinycolor(displayValue.color).setAlpha(0.9).toRgbString(); } else if (mode === TableCellBackgroundDisplayMode.Gradient) { const bgColor2 = tinycolor(displayValue.color) .darken(10 * darkeningFactor)