From 9b21375d78c71e0482c0c662f4b5965b6c529ec6 Mon Sep 17 00:00:00 2001 From: Ashley Harrison Date: Mon, 19 Dec 2022 15:35:32 +0000 Subject: [PATCH] Chore: remove `@storybook/addon-knobs` package (#60524) remove @storybook/addon-knobs package --- .yarnrc.yml | 3 - packages/grafana-ui/.storybook/main.ts | 1 - packages/grafana-ui/package.json | 1 - .../src/components/Badge/Badge.story.tsx | 2 +- .../components/Input/AutoSizeInput.story.tsx | 2 +- .../utils/storybook/{knobs.ts => icons.ts} | 6 - yarn.lock | 288 +----------------- 7 files changed, 6 insertions(+), 297 deletions(-) rename packages/grafana-ui/src/utils/storybook/{knobs.ts => icons.ts} (58%) diff --git a/.yarnrc.yml b/.yarnrc.yml index f9ddba0c6bf..d6e62c457a7 100644 --- a/.yarnrc.yml +++ b/.yarnrc.yml @@ -30,9 +30,6 @@ packageExtensions: '@storybook/react@6.5.12': peerDependencies: '@storybook/manager-webpack5': 6.5.12 - '@storybook/addon-knobs@6.4.0': - dependencies: - '@storybook/client-api': '*' doctrine@3.0.0: dependencies: assert: 2.0.0 diff --git a/packages/grafana-ui/.storybook/main.ts b/packages/grafana-ui/.storybook/main.ts index e5b4f133d0f..ad5a021197e 100644 --- a/packages/grafana-ui/.storybook/main.ts +++ b/packages/grafana-ui/.storybook/main.ts @@ -41,7 +41,6 @@ const mainConfig: StorybookConfig = { }, }, '@storybook/addon-a11y', - '@storybook/addon-knobs', { name: '@storybook/preset-scss', options: { diff --git a/packages/grafana-ui/package.json b/packages/grafana-ui/package.json index f3529c2a36f..b8fdc62017d 100644 --- a/packages/grafana-ui/package.json +++ b/packages/grafana-ui/package.json @@ -121,7 +121,6 @@ "@storybook/addon-actions": "6.5.14", "@storybook/addon-docs": "6.5.14", "@storybook/addon-essentials": "6.5.14", - "@storybook/addon-knobs": "6.4.0", "@storybook/addon-storysource": "6.5.14", "@storybook/addons": "6.5.14", "@storybook/api": "6.5.14", diff --git a/packages/grafana-ui/src/components/Badge/Badge.story.tsx b/packages/grafana-ui/src/components/Badge/Badge.story.tsx index c651bb07200..f19a3dfd48f 100644 --- a/packages/grafana-ui/src/components/Badge/Badge.story.tsx +++ b/packages/grafana-ui/src/components/Badge/Badge.story.tsx @@ -3,7 +3,7 @@ import React from 'react'; import { Badge } from '@grafana/ui'; -import { iconOptions } from '../../utils/storybook/knobs'; +import { iconOptions } from '../../utils/storybook/icons'; import { withCenteredStory } from '../../utils/storybook/withCenteredStory'; import mdx from './Badge.mdx'; diff --git a/packages/grafana-ui/src/components/Input/AutoSizeInput.story.tsx b/packages/grafana-ui/src/components/Input/AutoSizeInput.story.tsx index 6585896cb52..b7e646df2c3 100644 --- a/packages/grafana-ui/src/components/Input/AutoSizeInput.story.tsx +++ b/packages/grafana-ui/src/components/Input/AutoSizeInput.story.tsx @@ -3,7 +3,7 @@ import React from 'react'; import { Button, AutoSizeInput } from '@grafana/ui'; -import { iconOptions } from '../../utils/storybook/knobs'; +import { iconOptions } from '../../utils/storybook/icons'; import { withCenteredStory } from '../../utils/storybook/withCenteredStory'; import mdx from './AutoSizeInput.mdx'; diff --git a/packages/grafana-ui/src/utils/storybook/knobs.ts b/packages/grafana-ui/src/utils/storybook/icons.ts similarity index 58% rename from packages/grafana-ui/src/utils/storybook/knobs.ts rename to packages/grafana-ui/src/utils/storybook/icons.ts index f9fe8152b69..c177e85c4c9 100644 --- a/packages/grafana-ui/src/utils/storybook/knobs.ts +++ b/packages/grafana-ui/src/utils/storybook/icons.ts @@ -1,9 +1,5 @@ -import { select } from '@storybook/addon-knobs'; - import { getAvailableIcons } from '../../types'; -const VISUAL_GROUP = 'Visual options'; - export const iconOptions = { None: undefined, ...getAvailableIcons().reduce>((prev, c) => { @@ -13,5 +9,3 @@ export const iconOptions = { }; }, {}), }; - -export const getIconKnob = () => select('Icon', iconOptions, undefined, VISUAL_GROUP); diff --git a/yarn.lock b/yarn.lock index 1a3b4a97a9e..bdf923bdf60 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3317,7 +3317,7 @@ __metadata: languageName: node linkType: hard -"@babel/runtime@npm:^7.14.0, @babel/runtime@npm:^7.17.8, @babel/runtime@npm:^7.18.3, @babel/runtime@npm:^7.4.4": +"@babel/runtime@npm:^7.14.0, @babel/runtime@npm:^7.17.8, @babel/runtime@npm:^7.18.3": version: 7.18.3 resolution: "@babel/runtime@npm:7.18.3" dependencies: @@ -4144,7 +4144,7 @@ __metadata: languageName: node linkType: hard -"@emotion/cache@npm:^10.0.27, @emotion/cache@npm:^10.0.9": +"@emotion/cache@npm:^10.0.27": version: 10.0.29 resolution: "@emotion/cache@npm:10.0.29" dependencies: @@ -4195,22 +4195,6 @@ __metadata: languageName: node linkType: hard -"@emotion/core@npm:^10.0.9": - version: 10.3.1 - resolution: "@emotion/core@npm:10.3.1" - dependencies: - "@babel/runtime": ^7.5.5 - "@emotion/cache": ^10.0.27 - "@emotion/css": ^10.0.27 - "@emotion/serialize": ^0.11.15 - "@emotion/sheet": 0.9.4 - "@emotion/utils": 0.11.3 - peerDependencies: - react: ">=16.3.0" - checksum: d2dad428e1b2cf0777badfb55e262d369273be9b2e6e9e7d61c953066c00811d544a6234db36b17ee07872ed092f4dd102bf6ffe2c76fc38d53eef3a60fddfd0 - languageName: node - linkType: hard - "@emotion/css@npm:11.10.5": version: 11.10.5 resolution: "@emotion/css@npm:11.10.5" @@ -4229,17 +4213,6 @@ __metadata: languageName: node linkType: hard -"@emotion/css@npm:^10.0.27, @emotion/css@npm:^10.0.9": - version: 10.0.27 - resolution: "@emotion/css@npm:10.0.27" - dependencies: - "@emotion/serialize": ^0.11.15 - "@emotion/utils": 0.11.3 - babel-plugin-emotion: ^10.0.27 - checksum: 1420f5b514fc3a8500bcf90384b309b0d9acc9f687ec3a655166b55dc81d1661d6b6132ea6fe6730d0071c10da93bf9427937c22a90a18088af4ba5e11d59141 - languageName: node - linkType: hard - "@emotion/eslint-plugin@npm:11.10.0": version: 11.10.0 resolution: "@emotion/eslint-plugin@npm:11.10.0" @@ -5230,7 +5203,6 @@ __metadata: "@storybook/addon-actions": 6.5.14 "@storybook/addon-docs": 6.5.14 "@storybook/addon-essentials": 6.5.14 - "@storybook/addon-knobs": 6.4.0 "@storybook/addon-storysource": 6.5.14 "@storybook/addons": 6.5.14 "@storybook/api": 6.5.14 @@ -9079,38 +9051,6 @@ __metadata: languageName: node linkType: hard -"@storybook/addon-knobs@npm:6.4.0": - version: 6.4.0 - resolution: "@storybook/addon-knobs@npm:6.4.0" - dependencies: - copy-to-clipboard: ^3.3.1 - core-js: ^3.8.2 - escape-html: ^1.0.3 - fast-deep-equal: ^3.1.3 - global: ^4.4.0 - lodash: ^4.17.20 - prop-types: ^15.7.2 - qs: ^6.10.0 - react-colorful: ^5.1.2 - react-lifecycles-compat: ^3.0.4 - react-select: ^3.2.0 - peerDependencies: - "@storybook/addons": ^6.4.0 - "@storybook/api": ^6.4.0 - "@storybook/components": ^6.4.0 - "@storybook/core-events": ^6.4.0 - "@storybook/theming": ^6.4.0 - react: ^16.8.0 || ^17.0.0 - react-dom: ^16.8.0 || ^17.0.0 - peerDependenciesMeta: - react: - optional: true - react-dom: - optional: true - checksum: d9ea65af55e3983e7150aa0492f99027db06ca267eae5be19ace88f9733d1e858a35ba6cd0ff324f42fc32c03665ebf39e0f04777ec3b715300a2504de81a493 - languageName: node - linkType: hard - "@storybook/addon-measure@npm:6.5.14": version: 6.5.14 resolution: "@storybook/addon-measure@npm:6.5.14" @@ -9262,28 +9202,6 @@ __metadata: languageName: node linkType: hard -"@storybook/addons@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/addons@npm:6.5.7" - dependencies: - "@storybook/api": 6.5.7 - "@storybook/channels": 6.5.7 - "@storybook/client-logger": 6.5.7 - "@storybook/core-events": 6.5.7 - "@storybook/csf": 0.0.2--canary.4566f4d.1 - "@storybook/router": 6.5.7 - "@storybook/theming": 6.5.7 - "@types/webpack-env": ^1.16.0 - core-js: ^3.8.2 - global: ^4.4.0 - regenerator-runtime: ^0.13.7 - peerDependencies: - react: ^16.8.0 || ^17.0.0 || ^18.0.0 - react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 - checksum: 237f4537523f6a393aad07acc28338889dd668d8cbc46d75cc1837236c583de62fffd9b8a40c7386e552814a9636bed35fbd47a0cc5b3166461f82c6fe8a0931 - languageName: node - linkType: hard - "@storybook/api@npm:6.5.14, @storybook/api@npm:^6.5.14": version: 6.5.14 resolution: "@storybook/api@npm:6.5.14" @@ -9312,34 +9230,6 @@ __metadata: languageName: node linkType: hard -"@storybook/api@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/api@npm:6.5.7" - dependencies: - "@storybook/channels": 6.5.7 - "@storybook/client-logger": 6.5.7 - "@storybook/core-events": 6.5.7 - "@storybook/csf": 0.0.2--canary.4566f4d.1 - "@storybook/router": 6.5.7 - "@storybook/semver": ^7.3.2 - "@storybook/theming": 6.5.7 - core-js: ^3.8.2 - fast-deep-equal: ^3.1.3 - global: ^4.4.0 - lodash: ^4.17.21 - memoizerific: ^1.11.3 - regenerator-runtime: ^0.13.7 - store2: ^2.12.0 - telejson: ^6.0.8 - ts-dedent: ^2.0.0 - util-deprecate: ^1.0.2 - peerDependencies: - react: ^16.8.0 || ^17.0.0 || ^18.0.0 - react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 - checksum: 84f43121f8fee7df2061be357621c3a5e13de8e49efadbfbaa08ee188aab4d2fbec4daf84b6d8d03cc16f897a20458916f482e57d998a1a59e20b1943094291a - languageName: node - linkType: hard - "@storybook/builder-webpack4@npm:6.5.14": version: 6.5.14 resolution: "@storybook/builder-webpack4@npm:6.5.14" @@ -9468,21 +9358,6 @@ __metadata: languageName: node linkType: hard -"@storybook/channel-postmessage@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/channel-postmessage@npm:6.5.7" - dependencies: - "@storybook/channels": 6.5.7 - "@storybook/client-logger": 6.5.7 - "@storybook/core-events": 6.5.7 - core-js: ^3.8.2 - global: ^4.4.0 - qs: ^6.10.0 - telejson: ^6.0.8 - checksum: 4683d689fe065dd0de3583624e25b285a160f54bdc6681baef5fa4ad166c1fc654a447169247e7caca7a418d61aac537784728feb520361ecd2244b4ef34683d - languageName: node - linkType: hard - "@storybook/channel-websocket@npm:6.5.14": version: 6.5.14 resolution: "@storybook/channel-websocket@npm:6.5.14" @@ -9507,48 +9382,6 @@ __metadata: languageName: node linkType: hard -"@storybook/channels@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/channels@npm:6.5.7" - dependencies: - core-js: ^3.8.2 - ts-dedent: ^2.0.0 - util-deprecate: ^1.0.2 - checksum: 41b83607ef937ffef8d81beef6936e86d02cc14ad7159258ed94deedda8f495f095e26e9088557d547b3b1044cdb4e5501c21cdbbc0d4fb6c236b3b252d3cee3 - languageName: node - linkType: hard - -"@storybook/client-api@npm:*": - version: 6.5.7 - resolution: "@storybook/client-api@npm:6.5.7" - dependencies: - "@storybook/addons": 6.5.7 - "@storybook/channel-postmessage": 6.5.7 - "@storybook/channels": 6.5.7 - "@storybook/client-logger": 6.5.7 - "@storybook/core-events": 6.5.7 - "@storybook/csf": 0.0.2--canary.4566f4d.1 - "@storybook/store": 6.5.7 - "@types/qs": ^6.9.5 - "@types/webpack-env": ^1.16.0 - core-js: ^3.8.2 - fast-deep-equal: ^3.1.3 - global: ^4.4.0 - lodash: ^4.17.21 - memoizerific: ^1.11.3 - qs: ^6.10.0 - regenerator-runtime: ^0.13.7 - store2: ^2.12.0 - synchronous-promise: ^2.0.15 - ts-dedent: ^2.0.0 - util-deprecate: ^1.0.2 - peerDependencies: - react: ^16.8.0 || ^17.0.0 || ^18.0.0 - react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 - checksum: 30ba0b361833a750d60d1ceba91e8c8b7802aa9ab2de894d390b08dd9f415f5a8b7387604f8bc004de95ac4d7cd46e045c7e8e5bf7d12dc6f44f12f826370992 - languageName: node - linkType: hard - "@storybook/client-api@npm:6.5.14": version: 6.5.14 resolution: "@storybook/client-api@npm:6.5.14" @@ -9590,16 +9423,6 @@ __metadata: languageName: node linkType: hard -"@storybook/client-logger@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/client-logger@npm:6.5.7" - dependencies: - core-js: ^3.8.2 - global: ^4.4.0 - checksum: 5e8e0f24154bc8888cb0800320c4a054da166cb363e744a787a1fd42ead4cd97b7169f2a1a4696ece470974a41c4682a2aa78e384ca007493dc6579bdc5c0ccc - languageName: node - linkType: hard - "@storybook/components@npm:6.5.14, @storybook/components@npm:^6.5.14": version: 6.5.14 resolution: "@storybook/components@npm:6.5.14" @@ -9727,15 +9550,6 @@ __metadata: languageName: node linkType: hard -"@storybook/core-events@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/core-events@npm:6.5.7" - dependencies: - core-js: ^3.8.2 - checksum: 8abefa1453981dce5bb121068c8c1bb49d5aa13fc547308a26b6c7babe4d5dbf16195d590c11306d5edfc9b8f566e9562f30cd7c45190269df77d90a9d939516 - languageName: node - linkType: hard - "@storybook/core-server@npm:6.5.14": version: 6.5.14 resolution: "@storybook/core-server@npm:6.5.14" @@ -10160,20 +9974,6 @@ __metadata: languageName: node linkType: hard -"@storybook/router@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/router@npm:6.5.7" - dependencies: - "@storybook/client-logger": 6.5.7 - core-js: ^3.8.2 - regenerator-runtime: ^0.13.7 - peerDependencies: - react: ^16.8.0 || ^17.0.0 || ^18.0.0 - react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 - checksum: 455d17898a5ef1a6caba6d25381c77cdbd00ae98c3fdb5fd0bb9f0b9d0e4a471197fd94de052fb5cfa141d9a3c5fb2d25995c5b2a48eabf43926f782abe2dab3 - languageName: node - linkType: hard - "@storybook/semver@npm:^7.3.2": version: 7.3.2 resolution: "@storybook/semver@npm:7.3.2" @@ -10233,32 +10033,6 @@ __metadata: languageName: node linkType: hard -"@storybook/store@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/store@npm:6.5.7" - dependencies: - "@storybook/addons": 6.5.7 - "@storybook/client-logger": 6.5.7 - "@storybook/core-events": 6.5.7 - "@storybook/csf": 0.0.2--canary.4566f4d.1 - core-js: ^3.8.2 - fast-deep-equal: ^3.1.3 - global: ^4.4.0 - lodash: ^4.17.21 - memoizerific: ^1.11.3 - regenerator-runtime: ^0.13.7 - slash: ^3.0.0 - stable: ^0.1.8 - synchronous-promise: ^2.0.15 - ts-dedent: ^2.0.0 - util-deprecate: ^1.0.2 - peerDependencies: - react: ^16.8.0 || ^17.0.0 || ^18.0.0 - react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 - checksum: a92f14c5741dbf45dcbcaf492bae294b2c9663b58d0a25cdf47c522304d19f7021c4362aebae898670f51f5f559958f625b53a40d269184c0990bd053fbb992e - languageName: node - linkType: hard - "@storybook/telemetry@npm:6.5.14": version: 6.5.14 resolution: "@storybook/telemetry@npm:6.5.14" @@ -10294,20 +10068,6 @@ __metadata: languageName: node linkType: hard -"@storybook/theming@npm:6.5.7": - version: 6.5.7 - resolution: "@storybook/theming@npm:6.5.7" - dependencies: - "@storybook/client-logger": 6.5.7 - core-js: ^3.8.2 - regenerator-runtime: ^0.13.7 - peerDependencies: - react: ^16.8.0 || ^17.0.0 || ^18.0.0 - react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 - checksum: 2739a994a1e34d61d148107d28fd64665f2f6e1a2f8e02157beb64a564871ec2596573ae0f3bd5aed6887656b55befe1d0b3e7198f0730f2e087aee5f749d056 - languageName: node - linkType: hard - "@storybook/ui@npm:6.5.14": version: 6.5.14 resolution: "@storybook/ui@npm:6.5.14" @@ -19663,7 +19423,7 @@ __metadata: languageName: node linkType: hard -"escape-html@npm:^1.0.3, escape-html@npm:~1.0.3": +"escape-html@npm:~1.0.3": version: 1.0.3 resolution: "escape-html@npm:1.0.3" checksum: 6213ca9ae00d0ab8bccb6d8d4e0a98e76237b2410302cf7df70aaa6591d509a2a37ce8998008cbecae8fc8ffaadf3fb0229535e6a145f3ce0b211d060decbb24 @@ -27565,7 +27325,7 @@ __metadata: languageName: node linkType: hard -"memoize-one@npm:>=3.1.1 <6, memoize-one@npm:^5.0.0, memoize-one@npm:^5.0.4, memoize-one@npm:^5.1.1": +"memoize-one@npm:>=3.1.1 <6, memoize-one@npm:^5.0.4, memoize-one@npm:^5.1.1": version: 5.2.1 resolution: "memoize-one@npm:5.2.1" checksum: a3cba7b824ebcf24cdfcd234aa7f86f3ad6394b8d9be4c96ff756dafb8b51c7f71320785fbc2304f1af48a0467cbbd2a409efc9333025700ed523f254cb52e3d @@ -32715,16 +32475,6 @@ __metadata: languageName: node linkType: hard -"react-colorful@npm:^5.1.2": - version: 5.5.1 - resolution: "react-colorful@npm:5.5.1" - peerDependencies: - react: ">=16.8.0" - react-dom: ">=16.8.0" - checksum: e60811781716e57f0990379eff20d6f22d4d35b9e858c47ecf857c1dc1c1a2274c924ded7248bad5f1e2fbf2aab06e59b12852910c8dee5e6850f8e4df293670 - languageName: node - linkType: hard - "react-compat-css-styled@npm:^1.0.9": version: 1.0.9 resolution: "react-compat-css-styled@npm:1.0.9" @@ -33076,17 +32826,6 @@ __metadata: languageName: node linkType: hard -"react-input-autosize@npm:^3.0.0": - version: 3.0.0 - resolution: "react-input-autosize@npm:3.0.0" - dependencies: - prop-types: ^15.5.8 - peerDependencies: - react: ^16.3.0 || ^17.0.0 - checksum: cc3309ddc87446ade742c7d0e88ef089dd8b6981f21506a2bb27daf01a8803ac697f64157c4ffc7e81dfcf3892b54a4072dbc3652fd9addcf6d22dd0b87ab723 - languageName: node - linkType: hard - "react-inspector@npm:^5.1.0": version: 5.1.1 resolution: "react-inspector@npm:5.1.1" @@ -33329,25 +33068,6 @@ __metadata: languageName: node linkType: hard -"react-select@npm:^3.2.0": - version: 3.2.0 - resolution: "react-select@npm:3.2.0" - dependencies: - "@babel/runtime": ^7.4.4 - "@emotion/cache": ^10.0.9 - "@emotion/core": ^10.0.9 - "@emotion/css": ^10.0.9 - memoize-one: ^5.0.0 - prop-types: ^15.6.0 - react-input-autosize: ^3.0.0 - react-transition-group: ^4.3.0 - peerDependencies: - react: ^16.8.0 || ^17.0.0 - react-dom: ^16.8.0 || ^17.0.0 - checksum: 082c818369fb8c7ce50bbd51260b21794f58dd41e9df5e0798c10e10478fb44b9fd88247f24720d5b443d77a6ec8afa733ecdd15a7722fde85c27bb87c379962 - languageName: node - linkType: hard - "react-shallow-renderer@npm:^16.13.1": version: 16.14.1 resolution: "react-shallow-renderer@npm:16.14.1"