From 9b2c2be82d643632cbc48112595c068e89851c0f Mon Sep 17 00:00:00 2001
From: linoman <2051016+linoman@users.noreply.github.com>
Date: Fri, 6 Sep 2024 15:13:22 +0200
Subject: [PATCH] SSO LDAP: Add login form alert (#93037)

* add alert if login form is disabled

* add i18n texts
---
 public/app/features/admin/ldap/LdapSettingsPage.tsx | 10 ++++++++++
 public/locales/en-US/grafana.json                   |  4 ++++
 public/locales/pseudo-LOCALE/grafana.json           |  4 ++++
 3 files changed, 18 insertions(+)

diff --git a/public/app/features/admin/ldap/LdapSettingsPage.tsx b/public/app/features/admin/ldap/LdapSettingsPage.tsx
index 5d5e4885714..cc0cf54015c 100644
--- a/public/app/features/admin/ldap/LdapSettingsPage.tsx
+++ b/public/app/features/admin/ldap/LdapSettingsPage.tsx
@@ -218,9 +218,19 @@ export const LdapSettingsPage = () => {
     </Trans>
   );
 
+  const disabledFormAlert = (
+    <Alert title={t('ldap-settings-page.login-form-alert.title', 'Basic login disabled')}>
+      <Trans i18nKey="ldap-settings-page.login-form-alert.description">
+        Your LDAP configuration is not working because the basic login form is currently disabled. Please enable the
+        login form to use LDAP authentication. You can enable it on the Authentication page under “Auth settings”.
+      </Trans>
+    </Alert>
+  );
+
   return (
     <Page navId="authentication" pageNav={pageNav} subTitle={subTitle}>
       <Page.Contents>
+        {config.disableLoginForm && disabledFormAlert}
         <FormProvider {...methods}>
           <form onSubmit={handleSubmit(submitAndEnableLdapSettings, onErrors)}>
             {isLoading && <Loader />}
diff --git a/public/locales/en-US/grafana.json b/public/locales/en-US/grafana.json
index 8d5f32cff7d..99631238344 100644
--- a/public/locales/en-US/grafana.json
+++ b/public/locales/en-US/grafana.json
@@ -1133,6 +1133,10 @@
       "label": "Server host",
       "placeholder": "example: 127.0.0.1"
     },
+    "login-form-alert": {
+      "description": "Your LDAP configuration is not working because the basic login form is currently disabled. Please enable the login form to use LDAP authentication. You can enable it on the Authentication page under “Auth settings”.",
+      "title": "Basic login disabled"
+    },
     "search_filter": {
       "description": "LDAP search filter used to locate specific entries within the directory.",
       "label": "Search filter*",
diff --git a/public/locales/pseudo-LOCALE/grafana.json b/public/locales/pseudo-LOCALE/grafana.json
index 77e98815d57..436de096e2c 100644
--- a/public/locales/pseudo-LOCALE/grafana.json
+++ b/public/locales/pseudo-LOCALE/grafana.json
@@ -1133,6 +1133,10 @@
       "label": "Ŝęřvęř ĥőşŧ",
       "placeholder": "ęχämpľę: 127.0.0.1"
     },
+    "login-form-alert": {
+      "description": "Ÿőūř ĿĐÅP čőʼnƒįģūřäŧįőʼn įş ʼnőŧ ŵőřĸįʼnģ þęčäūşę ŧĥę þäşįč ľőģįʼn ƒőřm įş čūřřęʼnŧľy đįşäþľęđ. Pľęäşę ęʼnäþľę ŧĥę ľőģįʼn ƒőřm ŧő ūşę ĿĐÅP äūŧĥęʼnŧįčäŧįőʼn. Ÿőū čäʼn ęʼnäþľę įŧ őʼn ŧĥę Åūŧĥęʼnŧįčäŧįőʼn päģę ūʼnđęř “Åūŧĥ şęŧŧįʼnģş”.",
+      "title": "ßäşįč ľőģįʼn đįşäþľęđ"
+    },
     "search_filter": {
       "description": "ĿĐÅP şęäřčĥ ƒįľŧęř ūşęđ ŧő ľőčäŧę şpęčįƒįč ęʼnŧřįęş ŵįŧĥįʼn ŧĥę đįřęčŧőřy.",
       "label": "Ŝęäřčĥ ƒįľŧęř*",