From 9b9ac45295b7c14cf45ecc7e5ffe035c3fa2b0e7 Mon Sep 17 00:00:00 2001
From: Patrick O'Carroll <ocarroll.patrick@gmail.com>
Date: Tue, 12 Dec 2017 14:05:24 +0100
Subject: [PATCH] redesigning links editor

---
 public/app/features/dashlinks/editor.html | 10 ++++------
 public/app/features/dashlinks/editor.ts   | 22 +++++++++-------------
 2 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/public/app/features/dashlinks/editor.html b/public/app/features/dashlinks/editor.html
index 471055bc8fc..2529f32f0b9 100644
--- a/public/app/features/dashlinks/editor.html
+++ b/public/app/features/dashlinks/editor.html
@@ -12,7 +12,7 @@
       <div class="empty-list-cta__title">
         There are no dashboard links added yet
       </div>
-      <a ng-click="ctrl.addLinkMode()" class="empty-list-cta__button btn btn-xlarge btn-success">
+      <a ng-click="ctrl.addLink()" class="empty-list-cta__button btn btn-xlarge btn-success">
         <i class="gicon gicon-dashboard-new"></i>
         Add Dashboard Link
       </a>
@@ -33,7 +33,7 @@
   <div ng-if="ctrl.dashboard.links.length > 0">
     <div class="page-action-bar">
       <div class="page-action-bar__spacer"></div>
-      <a type="button" class="btn btn-success" ng-click="ctrl.addLinkMode()">
+      <a type="button" class="btn btn-success" ng-click="ctrl.addLink()">
         <i class="fa fa-plus"></i> New</a>
     </div>
     <table class="filter-table filter-table--hover">
@@ -126,8 +126,6 @@
       </div>
     </div>
   </div>
-  <button class="btn btn-success" ng-if="ctrl.mode == 'new'" ng-click="ctrl.addLink(link.type)">
-    <i class="fa fa-plus"></i> Add</button>
-  <button class="btn btn-success" ng-if="ctrl.mode == 'edit'" ng-click="ctrl.editLink()">
-    <i class="fa fa-plus"></i> Edit</button>
+  <button class="btn btn-success" ng-click="ctrl.saveLink()">
+    <i class="fa fa-plus"></i>Save</button>
 </div>
diff --git a/public/app/features/dashlinks/editor.ts b/public/app/features/dashlinks/editor.ts
index 11e69933800..56bab85a318 100644
--- a/public/app/features/dashlinks/editor.ts
+++ b/public/app/features/dashlinks/editor.ts
@@ -30,26 +30,22 @@ export class DashLinkEditorCtrl {
     this.mode = 'list';
   }
 
-  addLinkMode() {
-    this.mode = 'new';
-  }
-
-  editLinkMode(index) {
-    this.currentLink = index;
-    this.mode = 'edit';
-  }
-
-  addLink(type) {
-    this.dashboard.links.push({ type: type, icon: 'external link' });
-    //this.dashboard.updateSubmenuVisibility();
+  addLink() {
+    this.dashboard.links.push({ type: 'dashboard', icon: 'external link' });
+    this.dashboard.updateSubmenuVisibility();
     this.updated();
-    this.mode = 'list';
+    this.mode = 'new';
   }
 
   editLink(index) {
 
   }
 
+  saveLink() {
+    this.updated();
+    this.backToList();
+  }
+
   moveLink(index, dir) {
     _.move(this.dashboard.links, index, index+dir);
     this.updated();