From 9bb516e4e55ebbbdd732c5daa036c6b9c0ac6a63 Mon Sep 17 00:00:00 2001 From: Andrej Ocenas Date: Thu, 14 Jan 2021 14:18:41 +0100 Subject: [PATCH] Grafana-ui: Allow context menu items to be open in new tab (#30141) --- packages/grafana-ui/src/components/Menu/Menu.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/grafana-ui/src/components/Menu/Menu.tsx b/packages/grafana-ui/src/components/Menu/Menu.tsx index ef680ebb956..52c47b912e8 100644 --- a/packages/grafana-ui/src/components/Menu/Menu.tsx +++ b/packages/grafana-ui/src/components/Menu/Menu.tsx @@ -120,7 +120,14 @@ const MenuItemComponent: React.FC = React.memo(({ url, icon, labe target={target} className={cx(className, styles.link)} onClick={e => { + // We can have both url and onClick and we want to allow user to open the link in new tab/window + const isSpecialKeyPressed = e.ctrlKey || e.metaKey || e.shiftKey; + if (isSpecialKeyPressed && url) { + return; + } + if (onClick) { + e.preventDefault(); onClick(e); } }}