From 9c44c7593626780b5f62a2c194884dd4b1aa3cbb Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Thu, 11 Oct 2018 19:51:54 +0200 Subject: [PATCH] pkg/services/alerting/notifiers/telegram.go: check error before close. See, $ gometalinter --vendor --deadline 6m --disable-all --enable=megacheck ./... pkg/services/alerting/notifiers/telegram.go:130:2:warning: should check returned error before deferring imageFile.Close() (SA5001) (megacheck) --- pkg/services/alerting/notifiers/telegram.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/services/alerting/notifiers/telegram.go b/pkg/services/alerting/notifiers/telegram.go index 5492de45d39..6c47c92972c 100644 --- a/pkg/services/alerting/notifiers/telegram.go +++ b/pkg/services/alerting/notifiers/telegram.go @@ -127,7 +127,13 @@ func (this *TelegramNotifier) buildMessageInlineImage(evalContext *alerting.Eval var err error imageFile, err = os.Open(evalContext.ImageOnDiskPath) - defer imageFile.Close() + defer func() { + err := imageFile.Close() + if err != nil { + log.Error2("Could not close Telegram inline image.", "err", err) + } + }() + if err != nil { return nil, err }