Build: clean up and document integration test convention (#58170)

* clean up and document integration test convention

* clarify integration test conventions

* clean up integration tests that don't follow convention

* mark testIntegration* functions as helpers to avoid confusion

pkg/services/dashboardversion/dashverimpl/sqlx_store_test.go

@@ -7,6 +7,9 @@ import (
 )
 
 func TestIntegrationSQLxGetDashboardVersion(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skipping integration test")
+	}
 	testIntegrationGetDashboardVersion(t, func(ss db.DB) store {
 		return &sqlxStore{
 			sess: ss.GetSqlxSession(),

pkg/services/dashboardversion/dashverimpl/store_test.go

@@ -19,9 +19,8 @@ import (
 type getStore func(db.DB) store
 
 func testIntegrationGetDashboardVersion(t *testing.T, fn getStore) {
-	if testing.Short() {
-		t.Skip("skipping integration test")
-	}
+	t.Helper()
+
 	ss := db.InitTestDB(t)
 	dashVerStore := fn(ss)
 

pkg/services/dashboardversion/dashverimpl/xorm_store_test.go

@@ -7,6 +7,9 @@ import (
 )
 
 func TestIntegrationXORMGetDashboardVersion(t *testing.T) {
+	if testing.Short() {
+		t.Skip("skipping integration test")
+	}
 	testIntegrationGetDashboardVersion(t, func(ss db.DB) store {
 		return &sqlStore{
 			db:      ss,