From 9eafc693b2a4266636bf03265e0f1a0b88af1d32 Mon Sep 17 00:00:00 2001 From: Brian Gann Date: Thu, 12 Sep 2019 18:44:31 +0200 Subject: [PATCH] MSSQL: Fix memory leak when debug enabled (#19049) * fix for #19049 --- pkg/tsdb/mssql/mssql.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/tsdb/mssql/mssql.go b/pkg/tsdb/mssql/mssql.go index 82e15727e2f..692142246da 100644 --- a/pkg/tsdb/mssql/mssql.go +++ b/pkg/tsdb/mssql/mssql.go @@ -68,8 +68,9 @@ func (t *mssqlRowTransformer) Transform(columnTypes []*sql.ColumnType, rows *cor values := make([]interface{}, len(columnTypes)) valuePtrs := make([]interface{}, len(columnTypes)) - for i, stype := range columnTypes { - t.log.Debug("type", "type", stype) + for i := range columnTypes { + // debug output on large tables causes high memory utilization/leak + // t.log.Debug("type", "type", stype) valuePtrs[i] = &values[i] }