From a01d8a08712847b7eb5a22d5e3d0cb13650b6603 Mon Sep 17 00:00:00 2001 From: Stephanie Hingtgen Date: Wed, 9 Apr 2025 12:53:43 -0600 Subject: [PATCH] K8s: Dashboards: Allow userID to not be set for quota check (#103745) --- pkg/registry/apis/dashboard/register.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/pkg/registry/apis/dashboard/register.go b/pkg/registry/apis/dashboard/register.go index e75a39c3187..f78b0b50b82 100644 --- a/pkg/registry/apis/dashboard/register.go +++ b/pkg/registry/apis/dashboard/register.go @@ -267,11 +267,6 @@ func (b *DashboardsAPIBuilder) validateCreate(ctx context.Context, a admission.A return fmt.Errorf("error getting requester: %w", err) } - internalId, err := id.GetInternalID() - if err != nil { - return fmt.Errorf("error getting internal ID: %w", err) - } - // Validate folder existence if specified if !a.IsDryRun() && accessor.GetFolder() != "" { if err := b.validateFolderExists(ctx, accessor.GetFolder(), id.GetOrgID()); err != nil { @@ -283,7 +278,10 @@ func (b *DashboardsAPIBuilder) validateCreate(ctx context.Context, a admission.A if !a.IsDryRun() { params := "a.ScopeParameters{} params.OrgID = id.GetOrgID() - params.UserID = internalId + internalId, err := id.GetInternalID() + if err == nil { + params.UserID = internalId + } quotaReached, err := b.QuotaService.CheckQuotaReached(ctx, dashboards.QuotaTargetSrv, params) if err != nil && !errors.Is(err, quota.ErrDisabled) {