From a1b1d2fe80d17927b5157908838a53f8bdbb65c1 Mon Sep 17 00:00:00 2001
From: Dan Cech <dcech@grafana.com>
Date: Fri, 23 Mar 2018 11:16:11 -0400
Subject: [PATCH] switch to Result

---
 pkg/api/login_oauth.go            |  6 +++---
 pkg/login/ext_user.go             | 10 +++++-----
 pkg/login/ldap.go                 |  2 +-
 pkg/middleware/auth_proxy.go      |  6 +++---
 pkg/middleware/middleware_test.go |  6 +++---
 pkg/models/user_auth.go           |  2 +-
 6 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/pkg/api/login_oauth.go b/pkg/api/login_oauth.go
index 38ded183947..0a2800257d0 100644
--- a/pkg/api/login_oauth.go
+++ b/pkg/api/login_oauth.go
@@ -164,18 +164,18 @@ func OAuthLogin(ctx *m.ReqContext) {
 	}
 
 	// add/update user in grafana
-	userQuery := &m.UpsertUserCommand{
+	cmd := &m.UpsertUserCommand{
 		ExternalUser:  &extUser,
 		SignupAllowed: connect.IsSignupAllowed(),
 	}
-	err = login.UpsertUser(ctx, userQuery)
+	err = login.UpsertUser(ctx, cmd)
 	if err != nil {
 		redirectWithError(ctx, err)
 		return
 	}
 
 	// login
-	loginUserWithUser(userQuery.User, ctx)
+	loginUserWithUser(cmd.Result, ctx)
 
 	metrics.M_Api_Login_OAuth.Inc()
 
diff --git a/pkg/login/ext_user.go b/pkg/login/ext_user.go
index 82ebcf481b9..05eef3e35dd 100644
--- a/pkg/login/ext_user.go
+++ b/pkg/login/ext_user.go
@@ -39,15 +39,15 @@ var UpsertUser = func(ctx *m.ReqContext, cmd *m.UpsertUserCommand) error {
 			return ErrUsersQuotaReached
 		}
 
-		cmd.User, err = createUser(extUser)
+		cmd.Result, err = createUser(extUser)
 		if err != nil {
 			return err
 		}
 	} else {
-		cmd.User = userQuery.User
+		cmd.Result = userQuery.User
 
 		// sync user info
-		err = updateUser(cmd.User, extUser)
+		err = updateUser(cmd.Result, extUser)
 		if err != nil {
 			return err
 		}
@@ -55,7 +55,7 @@ var UpsertUser = func(ctx *m.ReqContext, cmd *m.UpsertUserCommand) error {
 
 	if userQuery.UserAuth == nil && extUser.AuthModule != "" && extUser.AuthId != "" {
 		cmd2 := m.SetAuthInfoCommand{
-			UserId:     cmd.User.Id,
+			UserId:     cmd.Result.Id,
 			AuthModule: extUser.AuthModule,
 			AuthId:     extUser.AuthId,
 		}
@@ -64,7 +64,7 @@ var UpsertUser = func(ctx *m.ReqContext, cmd *m.UpsertUserCommand) error {
 		}
 	}
 
-	err = syncOrgRoles(cmd.User, extUser)
+	err = syncOrgRoles(cmd.Result, extUser)
 	if err != nil {
 		return err
 	}
diff --git a/pkg/login/ldap.go b/pkg/login/ldap.go
index fd98320008e..5f7f44f2df5 100644
--- a/pkg/login/ldap.go
+++ b/pkg/login/ldap.go
@@ -199,7 +199,7 @@ func (a *ldapAuther) GetGrafanaUserFor(ctx *m.ReqContext, ldapUser *LdapUserInfo
 		return nil, err
 	}
 
-	return userQuery.User, nil
+	return userQuery.Result, nil
 }
 
 func (a *ldapAuther) serverBind() error {
diff --git a/pkg/middleware/auth_proxy.go b/pkg/middleware/auth_proxy.go
index 424d0719f50..0da0a460a8b 100644
--- a/pkg/middleware/auth_proxy.go
+++ b/pkg/middleware/auth_proxy.go
@@ -71,17 +71,17 @@ func initContextWithAuthProxy(ctx *m.ReqContext, orgID int64) bool {
 		}
 
 		// add/update user in grafana
-		userQuery := &m.UpsertUserCommand{
+		cmd := &m.UpsertUserCommand{
 			ExternalUser:  &extUser,
 			SignupAllowed: setting.AuthProxyAutoSignUp,
 		}
-		err := login.UpsertUser(ctx, userQuery)
+		err := login.UpsertUser(ctx, cmd)
 		if err != nil {
 			ctx.Handle(500, "Failed to login as user specified in auth proxy header", err)
 			return true
 		}
 
-		query.UserId = userQuery.User.Id
+		query.UserId = cmd.Result.Id
 
 		if err := bus.Dispatch(query); err != nil {
 			ctx.Handle(500, "Failed to find user", err)
diff --git a/pkg/middleware/middleware_test.go b/pkg/middleware/middleware_test.go
index b7a6afa47aa..a2cccf1fd5f 100644
--- a/pkg/middleware/middleware_test.go
+++ b/pkg/middleware/middleware_test.go
@@ -184,7 +184,7 @@ func TestMiddlewareContext(t *testing.T) {
 			})
 
 			login.UpsertUser = func(ctx *m.ReqContext, cmd *m.UpsertUserCommand) error {
-				cmd.User = &m.User{Id: 12}
+				cmd.Result = &m.User{Id: 12}
 				return nil
 			}
 
@@ -215,7 +215,7 @@ func TestMiddlewareContext(t *testing.T) {
 			})
 
 			login.UpsertUser = func(ctx *m.ReqContext, cmd *m.UpsertUserCommand) error {
-				cmd.User = &m.User{Id: 33}
+				cmd.Result = &m.User{Id: 33}
 				return nil
 			}
 
@@ -277,7 +277,7 @@ func TestMiddlewareContext(t *testing.T) {
 			})
 
 			login.UpsertUser = func(ctx *m.ReqContext, cmd *m.UpsertUserCommand) error {
-				cmd.User = &m.User{Id: 33}
+				cmd.Result = &m.User{Id: 33}
 				return nil
 			}
 
diff --git a/pkg/models/user_auth.go b/pkg/models/user_auth.go
index 99c1a70c153..65d39e6f748 100644
--- a/pkg/models/user_auth.go
+++ b/pkg/models/user_auth.go
@@ -29,7 +29,7 @@ type UpsertUserCommand struct {
 	ExternalUser  *ExternalUserInfo
 	SignupAllowed bool
 
-	User *User
+	Result *User
 }
 
 type SetAuthInfoCommand struct {