public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alerting: Prevent simplified routing zero duration GroupInterval and RepeatInterval (#86561)

Browse Source 
Prevent zero duration GroupInterval and RepeatInterval
This commit is contained in:
Matthew Jacobson
2024-04-18 21:08:38 -04:00
committed by GitHub
parent 71445002b7
commit a20197229e
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/ngalert/models/notifications_test.go
+10
View File
@@ -74,6 +74,11 @@ func TestValidate(t *testing.T) {
notificationSettings: CopyNotificationSettings(validNotificationSettings(), NSMuts.WithGroupInterval(util.Pointer(-1*time.Second))),
expErrorContains: "group interval",
},
{
name: "group interval zero is invalid",
notificationSettings: CopyNotificationSettings(validNotificationSettings(), NSMuts.WithGroupInterval(util.Pointer(0*time.Second))),
expErrorContains: "group interval",
},
{
name: "repeat interval empty is valid",
notificationSettings: CopyNotificationSettings(validNotificationSettings(), NSMuts.WithRepeatInterval(nil)),
@@ -87,6 +92,11 @@ func TestValidate(t *testing.T) {
notificationSettings: CopyNotificationSettings(validNotificationSettings(), NSMuts.WithRepeatInterval(util.Pointer(-1*time.Second))),
expErrorContains: "repeat interval",
},
{
name: "repeat interval zero is invalid",
notificationSettings: CopyNotificationSettings(validNotificationSettings(), NSMuts.WithRepeatInterval(util.Pointer(0*time.Second))),
expErrorContains: "repeat interval",
},
}
for _, tt := range testCases {