CloudMigrations: Fix issues discovered during end to end testing (#90562)

* improve error handling a retries during async operations

* fix use of contexts

* updates to how we call the folder api

* fix urls for gms

* more progress on the folder issue

* fix folders

* refactor for readability

pkg/services/cloudmigration/cloudmigrationimpl/cloudmigration.go

@@ -501,6 +501,13 @@ func (s *Service) CreateSnapshot(ctx context.Context, signedInUser *user.SignedI
 	go func() {
 		if err := s.buildSnapshot(context.Background(), signedInUser, initResp.MaxItemsPerPartition, snapshot); err != nil {
 			s.log.Error("building snapshot", "err", err.Error())
+			// Update status to error with retries
+			if err := s.updateStatusWithRetries(context.Background(), cloudmigration.UpdateSnapshotCmd{
+				UID:    snapshot.UID,
+				Status: cloudmigration.SnapshotStatusError,
+			}); err != nil {
+				s.log.Error("critical failure during snapshot creation - please report any error logs")
+			}
 		}
 	}()
 
@@ -610,7 +617,14 @@ func (s *Service) UploadSnapshot(ctx context.Context, sessionUid string, snapsho
 	// start uploading the snapshot asynchronously while we return a success response to the client
 	go func() {
 		if err := s.uploadSnapshot(context.Background(), session, snapshot, uploadUrl); err != nil {
-			s.log.Error("uploading snapshot", "err", err)
+			s.log.Error("uploading snapshot", "err", err.Error())
+			// Update status to error with retries
+			if err := s.updateStatusWithRetries(context.Background(), cloudmigration.UpdateSnapshotCmd{
+				UID:    snapshot.UID,
+				Status: cloudmigration.SnapshotStatusError,
+			}); err != nil {
+				s.log.Error("critical failure during snapshot upload - please report any error logs")
+			}
 		}
 	}()