From a5a3ee9fa3f6171b87e2e804e4a4b9dd29ed7be0 Mon Sep 17 00:00:00 2001 From: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> Date: Wed, 24 Apr 2024 15:25:43 +0100 Subject: [PATCH] SQLStore: Disable redundant create and drop unique index migrations on dashboard table (#86857) SQLStore: Disable create and drop unique index migrations --- .../migrations/folder_uid_migrator.go | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/pkg/services/dashboards/database/migrations/folder_uid_migrator.go b/pkg/services/dashboards/database/migrations/folder_uid_migrator.go index 4db022cfd81..fd1a075c82f 100644 --- a/pkg/services/dashboards/database/migrations/folder_uid_migrator.go +++ b/pkg/services/dashboards/database/migrations/folder_uid_migrator.go @@ -5,6 +5,18 @@ import ( "xorm.io/xorm" ) +type DummyMigration struct { + migrator.MigrationBase +} + +func (m *DummyMigration) SQL(dialect migrator.Dialect) string { + return "code migration" +} + +func (m *DummyMigration) Exec(sess *xorm.Session, mgrtr *migrator.Migrator) error { + return nil +} + // FolderUIDMigration is a code migration that populates folder_uid column type FolderUIDMigration struct { migrator.MigrationBase @@ -78,17 +90,13 @@ func AddDashboardFolderMigrations(mg *migrator.Migrator) { mg.AddMigration("Populate dashboard folder_uid column", &FolderUIDMigration{}) - mg.AddMigration("Add unique index for dashboard_org_id_folder_uid_title", migrator.NewAddIndexMigration(migrator.Table{Name: "dashboard"}, &migrator.Index{ - Cols: []string{"org_id", "folder_uid", "title"}, Type: migrator.UniqueIndex, - })) + mg.AddMigration("Add unique index for dashboard_org_id_folder_uid_title", &DummyMigration{}) mg.AddMigration("Delete unique index for dashboard_org_id_folder_id_title", migrator.NewDropIndexMigration(migrator.Table{Name: "dashboard"}, &migrator.Index{ Cols: []string{"org_id", "folder_id", "title"}, Type: migrator.UniqueIndex, })) - mg.AddMigration("Delete unique index for dashboard_org_id_folder_uid_title", migrator.NewDropIndexMigration(migrator.Table{Name: "dashboard"}, &migrator.Index{ - Cols: []string{"org_id", "folder_uid", "title"}, Type: migrator.UniqueIndex, - })) + mg.AddMigration("Delete unique index for dashboard_org_id_folder_uid_title", &DummyMigration{}) mg.AddMigration("Add unique index for dashboard_org_id_folder_uid_title_is_folder", migrator.NewAddIndexMigration(migrator.Table{Name: "dashboard"}, &migrator.Index{ Cols: []string{"org_id", "folder_uid", "title", "is_folder"}, Type: migrator.UniqueIndex,