From a8971540178ce0267b8fcfceff561daab2c7dda5 Mon Sep 17 00:00:00 2001
From: Ashley Harrison <ashley.harrison@grafana.com>
Date: Thu, 25 Nov 2021 09:51:21 +0000
Subject: [PATCH] pally-ci: Ignore version update element (#42249)

* pa11y-ci: Ignore update version element

* Add hideElements to pa11yci-pr.conf.js
---
 .pa11yci-pr.conf.js                          | 5 +++--
 .pa11yci.conf.js                             | 1 +
 public/app/core/components/Footer/Footer.tsx | 4 +++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.pa11yci-pr.conf.js b/.pa11yci-pr.conf.js
index b6c28426292..308d95b6785 100644
--- a/.pa11yci-pr.conf.js
+++ b/.pa11yci-pr.conf.js
@@ -6,6 +6,7 @@ var config = {
     chromeLaunchConfig: {
       args: ['--no-sandbox'],
     },
+    hideElements: '#updateVersion',
   },
 
   urls: [
@@ -13,7 +14,7 @@ var config = {
       url: '${HOST}/login',
       wait: 500,
       rootElement: '.main-view',
-      threshold: 13,
+      threshold: 12,
     },
     {
       url: '${HOST}/login',
@@ -25,7 +26,7 @@ var config = {
         "click element button[aria-label='Login button']",
         "wait for element [aria-label='Skip change password button'] to be visible",
       ],
-      threshold: 14,
+      threshold: 13,
       rootElement: '.main-view',
     },
     {
diff --git a/.pa11yci.conf.js b/.pa11yci.conf.js
index 6b872fcf390..0d7a9c11361 100644
--- a/.pa11yci.conf.js
+++ b/.pa11yci.conf.js
@@ -6,6 +6,7 @@ var config = {
     chromeLaunchConfig: {
       args: ['--no-sandbox'],
     },
+    hideElements: '#updateVersion',
   },
 
   urls: [
diff --git a/public/app/core/components/Footer/Footer.tsx b/public/app/core/components/Footer/Footer.tsx
index 5b7be702bd2..9096de39106 100644
--- a/public/app/core/components/Footer/Footer.tsx
+++ b/public/app/core/components/Footer/Footer.tsx
@@ -4,6 +4,7 @@ import { Icon, IconName } from '@grafana/ui';
 
 export interface FooterLink {
   text: string;
+  id?: string;
   icon?: string;
   url?: string;
   target?: string;
@@ -47,6 +48,7 @@ export let getVersionLinks = (): FooterLink[] => {
 
   if (buildInfo.hasUpdate) {
     links.push({
+      id: 'updateVersion',
       text: `New version available!`,
       icon: 'download-alt',
       url: 'https://grafana.com/grafana/download?utm_source=grafana_footer',
@@ -74,7 +76,7 @@ export const Footer: FC = React.memo(() => {
         <ul>
           {links.map((link) => (
             <li key={link.text}>
-              <a href={link.url} target={link.target} rel="noopener">
+              <a href={link.url} target={link.target} rel="noopener" id={link.id}>
                 {link.icon && <Icon name={link.icon as IconName} />} {link.text}
               </a>
             </li>