From aaa55b42529f575a41eda6c5912c6e6d3265a71c Mon Sep 17 00:00:00 2001
From: Yuri Tseretyan <yuriy.tseretyan@grafana.com>
Date: Tue, 20 Dec 2022 14:20:09 -0500
Subject: [PATCH] Alerting: Update Kafka receiver to use encoding/json to build
 messages (#60593)

Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
---
 .../ngalert/notifier/channels/kafka.go        | 64 +++++++++++++------
 1 file changed, 43 insertions(+), 21 deletions(-)

diff --git a/pkg/services/ngalert/notifier/channels/kafka.go b/pkg/services/ngalert/notifier/channels/kafka.go
index 959a58fc196..32ab5dbc9cd 100644
--- a/pkg/services/ngalert/notifier/channels/kafka.go
+++ b/pkg/services/ngalert/notifier/channels/kafka.go
@@ -14,10 +14,32 @@ import (
 
 	"github.com/grafana/alerting/alerting/notifier/channels"
 
-	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/models"
 )
 
+type kafkaBody struct {
+	Records []kafkaRecordEnvelope `json:"records"`
+}
+
+type kafkaRecordEnvelope struct {
+	Value kafkaRecord `json:"value"`
+}
+
+type kafkaRecord struct {
+	Description string                `json:"description"`
+	Client      string                `json:"client,omitempty"`
+	Details     string                `json:"details,omitempty"`
+	AlertState  models.AlertStateType `json:"alert_state,omitempty"`
+	ClientURL   string                `json:"client_url,omitempty"`
+	Contexts    []kafkaContext        `json:"contexts,omitempty"`
+	IncidentKey string                `json:"incident_key,omitempty"`
+}
+
+type kafkaContext struct {
+	Type   string `json:"type"`
+	Source string `json:"src"`
+}
+
 // KafkaNotifier is responsible for sending
 // alert notifications to Kafka.
 type KafkaNotifier struct {
@@ -125,36 +147,36 @@ func (kn *KafkaNotifier) SendResolved() bool {
 }
 
 func (kn *KafkaNotifier) buildBody(ctx context.Context, tmpl func(string) string, as ...*types.Alert) (string, error) {
-	bodyJSON := simplejson.New()
-	bodyJSON.Set("client", "Grafana")
-	bodyJSON.Set("description", tmpl(kn.settings.Description))
-	bodyJSON.Set("details", tmpl(kn.settings.Details))
+	var record kafkaRecord
+	record.Client = "Grafana"
+	record.Description = tmpl(kn.settings.Description)
+	record.Details = tmpl(kn.settings.Details)
 
 	state := buildState(as...)
 	kn.log.Debug("notifying Kafka", "alert_state", state)
-	bodyJSON.Set("alert_state", state)
+	record.AlertState = state
 
 	ruleURL := joinUrlPath(kn.tmpl.ExternalURL.String(), "/alerting/list", kn.log)
-	bodyJSON.Set("client_url", ruleURL)
+	record.ClientURL = ruleURL
 
 	contexts := buildContextImages(ctx, kn.log, kn.images, as...)
 	if len(contexts) > 0 {
-		bodyJSON.Set("contexts", contexts)
+		record.Contexts = contexts
 	}
 
 	groupKey, err := notify.ExtractGroupKey(ctx)
 	if err != nil {
 		return "", err
 	}
-	bodyJSON.Set("incident_key", groupKey.Hash())
+	record.IncidentKey = groupKey.Hash()
 
-	valueJSON := simplejson.New()
-	valueJSON.Set("value", bodyJSON)
+	records := kafkaBody{
+		Records: []kafkaRecordEnvelope{
+			{Value: record},
+		},
+	}
 
-	recordJSON := simplejson.New()
-	recordJSON.Set("records", []interface{}{valueJSON})
-
-	body, err := recordJSON.MarshalJSON()
+	body, err := json.Marshal(records)
 	if err != nil {
 		return "", err
 	}
@@ -170,15 +192,15 @@ func buildState(as ...*types.Alert) models.AlertStateType {
 	return models.AlertStateAlerting
 }
 
-func buildContextImages(ctx context.Context, l channels.Logger, imageStore channels.ImageStore, as ...*types.Alert) []interface{} {
-	var contexts []interface{}
+func buildContextImages(ctx context.Context, l channels.Logger, imageStore channels.ImageStore, as ...*types.Alert) []kafkaContext {
+	var contexts []kafkaContext
 	_ = withStoredImages(ctx, l, imageStore,
 		func(_ int, image channels.Image) error {
 			if image.URL != "" {
-				imageJSON := simplejson.New()
-				imageJSON.Set("type", "image")
-				imageJSON.Set("src", image.URL)
-				contexts = append(contexts, imageJSON)
+				contexts = append(contexts, kafkaContext{
+					Type:   "image",
+					Source: image.URL,
+				})
 			}
 			return nil
 		}, as...)