diff --git a/public/app/core/components/AccessControl/AddPermission.tsx b/public/app/core/components/AccessControl/AddPermission.tsx index 6098f20a13e..070acef5c3e 100644 --- a/public/app/core/components/AccessControl/AddPermission.tsx +++ b/public/app/core/components/AccessControl/AddPermission.tsx @@ -1,6 +1,6 @@ import React, { useEffect, useMemo, useState } from 'react'; -import { Button, Form, Select, Stack } from '@grafana/ui'; +import { Button, Select, Stack } from '@grafana/ui'; import { CloseButton } from 'app/core/components/CloseButton/CloseButton'; import { ServiceAccountPicker } from 'app/core/components/Select/ServiceAccountPicker'; import { TeamPicker } from 'app/core/components/Select/TeamPicker'; @@ -71,54 +71,48 @@ export const AddPermission = ({
{title}
-
onAdd({ userId, teamId, builtInRole, permission, target })} - > - {() => ( - + onAdd({ userId, teamId, builtInRole, permission, target })}> + + setPermissionTarget(v.value!)} - disabled={targetOptions.length === 0} + aria-label={'Built-in role picker'} + options={Object.values(OrgRole) + .filter((r) => r !== OrgRole.None) + .map((r) => ({ value: r, label: r }))} + onChange={(r) => setBuiltinRole(r.value || '')} width="auto" /> + )} - {target === PermissionTarget.User && setUserId(u?.value || 0)} />} - - {target === PermissionTarget.ServiceAccount && ( - setUserId(u?.value || 0)} /> - )} - - {target === PermissionTarget.Team && setTeamId(t.value?.id || 0)} />} - - {target === PermissionTarget.BuiltInRole && ( - p === permission)} - options={permissions.map((p) => ({ label: p, value: p }))} - onChange={(v) => setPermission(v.value || '')} - /> - - - )} - +