From acd85314b34bf467fbd7b4fe1d0e356ca68a1cbb Mon Sep 17 00:00:00 2001 From: Michael Mandrus <41969079+mmandrus@users.noreply.github.com> Date: Tue, 19 Jul 2022 16:36:51 -0400 Subject: [PATCH] Secrets: Add logging to track secrets migration (#52481) * add logging to track migration * fix lint problem --- pkg/services/secrets/kvstore/plugin_mig.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/services/secrets/kvstore/plugin_mig.go b/pkg/services/secrets/kvstore/plugin_mig.go index 73cd082eef8..dcf9aad066e 100644 --- a/pkg/services/secrets/kvstore/plugin_mig.go +++ b/pkg/services/secrets/kvstore/plugin_mig.go @@ -41,6 +41,7 @@ func (s *PluginSecretMigrationService) Migrate(ctx context.Context) error { // Check if we should migrate to plugin - default false if s.cfg.SectionWithEnvOverrides("secrets").Key("migrate_to_plugin").MustBool(false) && s.remoteCheck.ShouldUseRemoteSecretsPlugin() { + s.logger.Debug("starting migration of unified secrets to the plugin") // we need to instantiate the secretsKVStore as this is not on wire, and in this scenario, // the secrets store would be the plugin. secretsSql := &secretsKVStoreSQL{ @@ -63,6 +64,7 @@ func (s *PluginSecretMigrationService) Migrate(ctx context.Context) error { return err } } + s.logger.Debug("migrated unified secrets to plugin", "number of secrets", len(allSec)) // as no err was returned, when we delete all the secrets from the sql store for _, sec := range allSec { err = secretsSql.Del(ctx, *sec.OrgId, *sec.Namespace, *sec.Type) @@ -70,6 +72,7 @@ func (s *PluginSecretMigrationService) Migrate(ctx context.Context) error { return err } } + s.logger.Debug("deleted unified secrets after migration", "number of secrets", len(allSec)) } return nil }