From ad6648b649b50b4b331bf8c2b89d721adcc0e0e5 Mon Sep 17 00:00:00 2001 From: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Date: Fri, 28 May 2021 19:36:30 +0530 Subject: [PATCH] Alerting: Do no hard fail on finding discontinued channels on migration (#34894) Signed-off-by: Ganesh Vernekar --- pkg/services/sqlstore/migrations/ualert/channel.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/services/sqlstore/migrations/ualert/channel.go b/pkg/services/sqlstore/migrations/ualert/channel.go index cc4070ef705..bf95deb716a 100644 --- a/pkg/services/sqlstore/migrations/ualert/channel.go +++ b/pkg/services/sqlstore/migrations/ualert/channel.go @@ -110,7 +110,8 @@ func (m *migration) makeReceiverAndRoute(ruleUid string, channelUids []interface addChannel := func(c *notificationChannel) error { if c.Type == "hipchat" || c.Type == "sensu" { - return fmt.Errorf("discontinued notification channel found: %s", c.Type) + m.mg.Logger.Error("alert migration error: discontinued notification channel found", "type", c.Type, "name", c.Name, "uid", c.Uid) + return nil } uid, ok := m.generateChannelUID() @@ -179,7 +180,8 @@ func (m *migration) updateDefaultAndUnmigratedChannels(amConfig *PostableUserCon continue } if c.Type == "hipchat" || c.Type == "sensu" { - return fmt.Errorf("discontinued notification channel found: %s", c.Type) + m.mg.Logger.Error("alert migration error: discontinued notification channel found", "type", c.Type, "name", c.Name, "uid", c.Uid) + continue } uid, ok := m.generateChannelUID()