From ada325de2a052538e9cda552f85acb788c8cad96 Mon Sep 17 00:00:00 2001 From: Yuri Tseretyan Date: Fri, 30 Jun 2023 14:58:23 -0400 Subject: [PATCH] Alerting: Use unsafe.Slice for hashing a string during rule fingerprint calculation (#71000) --- pkg/services/ngalert/schedule/registry.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/services/ngalert/schedule/registry.go b/pkg/services/ngalert/schedule/registry.go index 7495d6c64c8..202b645d312 100644 --- a/pkg/services/ngalert/schedule/registry.go +++ b/pkg/services/ngalert/schedule/registry.go @@ -263,12 +263,8 @@ func (r ruleWithFolder) Fingerprint() fingerprint { writeBytes(nil) return } - // TODO fix it when upgraded to in GO1.20 to - /* - writeBytes(unsafe.Slice(unsafe.StringData(s), len(s))) //nolint:gosec - */ // avoid allocation when converting string to byte slice - writeBytes(*(*[]byte)(unsafe.Pointer(&s))) //nolint:gosec + writeBytes(unsafe.Slice(unsafe.StringData(s), len(s))) } // this temp slice is used to convert ints to bytes. tmp := make([]byte, 8)