From aea860a3bd4e7a4e0599484683635f14ecbd96b6 Mon Sep 17 00:00:00 2001 From: matt abrams <37156449+zuchka@users.noreply.github.com> Date: Wed, 16 Nov 2022 17:46:12 +0100 Subject: [PATCH] DataLinks: Fix double dollar-sign bug in data-links editor (#58096) * fix template variable bug * fix bug when adding vars before existing vars * take 2--remove includeDollarSign logic * take 3-add includeDollarSign logic for template vars --- packages/grafana-ui/src/components/DataLinks/DataLinkInput.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/grafana-ui/src/components/DataLinks/DataLinkInput.tsx b/packages/grafana-ui/src/components/DataLinks/DataLinkInput.tsx index 127bf984819..b2e3d907610 100644 --- a/packages/grafana-ui/src/components/DataLinks/DataLinkInput.tsx +++ b/packages/grafana-ui/src/components/DataLinks/DataLinkInput.tsx @@ -141,7 +141,7 @@ export const DataLinkInput: React.FC = memo( if (item.origin !== VariableOrigin.Template || item.value === DataLinkBuiltInVars.includeVars) { editor.insertText(`${includeDollarSign ? '$' : ''}\{${item.value}}`); } else { - editor.insertText(`\${${item.value}:queryparam}`); + editor.insertText(`${includeDollarSign ? '$' : ''}\{${item.value}:queryparam}`); } setLinkUrl(editor.value);