From b16a8bd6a80e349cc0eca1afa8ff776a6a60db4e Mon Sep 17 00:00:00 2001 From: Andreas Christou Date: Thu, 20 Apr 2023 15:40:45 +0100 Subject: [PATCH] grafana/e2e: Put E2E select updates in selectOption (#66972) Put E2E select updates in selectOption and force --- packages/grafana-e2e/src/flows/configurePanel.ts | 7 ------- packages/grafana-e2e/src/flows/selectOption.ts | 7 ++++++- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/grafana-e2e/src/flows/configurePanel.ts b/packages/grafana-e2e/src/flows/configurePanel.ts index 983510e683a..c6225fb4a0d 100644 --- a/packages/grafana-e2e/src/flows/configurePanel.ts +++ b/packages/grafana-e2e/src/flows/configurePanel.ts @@ -113,13 +113,6 @@ export const configurePanel = (config: PartialAddPanelConfig | PartialEditPanelC e2e().intercept(chartData.method, chartData.route).as('chartData'); if (dataSourceName) { - e2e.components.DataSourcePicker.container().within(() => { - e2e() - .get('[class$="-input-suffix"]') - .then((element) => { - Cypress.dom.isAttached(element); - }); - }); selectOption({ container: e2e.components.DataSourcePicker.container(), optionText: dataSourceName, diff --git a/packages/grafana-e2e/src/flows/selectOption.ts b/packages/grafana-e2e/src/flows/selectOption.ts index 703fc9ad4a1..d47918c9fb5 100644 --- a/packages/grafana-e2e/src/flows/selectOption.ts +++ b/packages/grafana-e2e/src/flows/selectOption.ts @@ -19,7 +19,12 @@ export const selectOption = (config: SelectOptionConfig): any => { container.within(() => { if (clickToOpen) { - e2e().get('[class$="-input-suffix"]').click(); + e2e() + .get('[class$="-input-suffix"]', { timeout: 1000 }) + .then((element) => { + expect(Cypress.dom.isAttached(element)).to.eq(true); + e2e().get('[class$="-input-suffix"]', { timeout: 1000 }).click({ force: true }); + }); } });