public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CloudMigrations: wrap assert in EventuallyWithTf in case async sync hasnt finished (#110777)

Browse Source 
* CloudMigrations: wrap assert in EventuallyWithTf in case async sync hasnt finished

* fix

* fix
This commit is contained in:
lean.dev
2025-09-09 08:05:10 -03:00
committed by GitHub
parent 066c1787b9
commit b1a059ac4e
1 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/cloudmigration/cloudmigrationimpl/cloudmigration_test.go
+17 -15
View File
@@ -342,21 +342,23 @@ func Test_GetSnapshotStatusFromGMS(t *testing.T) {
require.NotNil(t, snapshot)
require.Eventually(t, func() bool { return gmsClientFake.GetSnapshotStatusCallCount() == 1 }, time.Second, 10*time.Millisecond)
snapshot, err = s.GetSnapshot(context.Background(), cloudmigration.GetSnapshotsQuery{
SnapshotUID: snapshotUID,
SessionUID: sessionUID,
SnapshotResultQueryParams: cloudmigration.SnapshotResultQueryParams{
ResultLimit: 10,
ResultPage: 1,
SortColumn: cloudmigration.SortColumnID,
SortOrder: cloudmigration.SortOrderAsc,
},
})
require.NoError(t, err)
require.NotNil(t, snapshot)
require.Len(t, snapshot.Resources, 1)
require.Equal(t, "A", snapshot.Resources[0].RefID)
require.Equal(t, "fake", snapshot.Resources[0].Error)
require.EventuallyWithTf(t, func(t *assert.CollectT) {
snapshot, err := s.GetSnapshot(context.Background(), cloudmigration.GetSnapshotsQuery{
SnapshotUID: snapshotUID,
SessionUID: sessionUID,
SnapshotResultQueryParams: cloudmigration.SnapshotResultQueryParams{
ResultLimit: 10,
ResultPage: 1,
SortColumn: cloudmigration.SortColumnID,
SortOrder: cloudmigration.SortOrderAsc,
},
})
assert.NoError(t, err)
assert.NotNil(t, snapshot)
assert.Len(t, snapshot.Resources, 1)
assert.Equal(t, "A", snapshot.Resources[0].RefID)
assert.Equal(t, "fake", snapshot.Resources[0].Error)
}, 5*time.Second, 100*time.Millisecond, "DB wasn't applied to local snapshot in time")
})
}