Chore: Replace short UID generation with more standard UUIDs (#62731)

pkg/services/sqlstore/migrations/ualert/permissions.go

@@ -101,12 +101,7 @@ func (m *folderHelper) createFolder(orgID int64, title string) (*dashboard, erro
 		}),
 	}
 	dash := cmd.getDashboardModel()
-
-	uid, err := m.generateNewDashboardUid(dash.OrgId)
-	if err != nil {
-		return nil, err
-	}
-	dash.setUid(uid)
+	dash.setUid(util.GenerateShortUID())
 
 	parentVersion := dash.Version
 	dash.setVersion(1)
@@ -116,7 +111,7 @@ func (m *folderHelper) createFolder(orgID int64, title string) (*dashboard, erro
 	dash.UpdatedBy = FOLDER_CREATED_BY
 	metrics.MApiDashboardInsert.Inc()
 
-	if _, err = m.sess.Insert(dash); err != nil {
+	if _, err := m.sess.Insert(dash); err != nil {
 		return nil, err
 	}
 
@@ -138,23 +133,6 @@ func (m *folderHelper) createFolder(orgID int64, title string) (*dashboard, erro
 	return dash, nil
 }
 
-func (m *folderHelper) generateNewDashboardUid(orgId int64) (string, error) {
-	for i := 0; i < 3; i++ {
-		uid := util.GenerateShortUID()
-
-		exists, err := m.sess.Where("org_id=? AND uid=?", orgId, uid).Get(&dashboards.Dashboard{})
-		if err != nil {
-			return "", err
-		}
-
-		if !exists {
-			return uid, nil
-		}
-	}
-
-	return "", dashboards.ErrDashboardFailedGenerateUniqueUid
-}
-
 // based on SQLStore.UpdateDashboardACL()
 // it should be called from inside a transaction
 func (m *folderHelper) setACL(orgID int64, dashboardID int64, items []*dashboardACL) error {