Chore: Upgrade Go to 1.19.1 (#54902)

* WIP

* Set public_suffix to a pre Ruby 2.6 version

* we don't need to install python

* Stretch->Buster

* Bump versions in lib.star

* Manually update linter

Sort of messy, but the .mod-file need to contain all dependencies that
use 1.16+ features, otherwise they're assumed to be compiled with
-lang=go1.16 and cannot access generics et al.

Bingo doesn't seem to understand that, but it's possible to manually
update things to get Bingo happy.

* undo reformatting

* Various lint improvements

* More from the linter

* goimports -w ./pkg/

* Disable gocritic

* Add/modify linter exceptions

* lint + flatten nested list

Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround.
https://go.dev/doc/comment#lists

pkg/services/sqlstore/migrations/ualert/silences.go

@@ -199,6 +199,7 @@ func openReplace(filename string) (*replaceFile, error) {
 		return nil, err
 	}
 
+	//nolint:gosec
 	f, err := os.Create(tmpFilename)
 	if err != nil {
 		return nil, err

pkg/services/sqlstore/migrations/ualert/ualert.go

@@ -232,7 +232,7 @@ func (m *migration) SQL(dialect migrator.Dialect) string {
 	return codeMigration
 }
 
-// nolint: gocyclo
+//nolint:gocyclo
 func (m *migration) Exec(sess *xorm.Session, mg *migrator.Migrator) error {
 	m.sess = sess
 	m.mg = mg

pkg/services/sqlstore/migrator/dialect.go

@@ -313,7 +313,7 @@ func (b *BaseDialect) TruncateDBTables() error {
 	return nil
 }
 
-//UpsertSQL returns empty string
+// UpsertSQL returns empty string
 func (b *BaseDialect) UpsertSQL(tableName string, keyCols, updateCols []string) string {
 	return ""
 }

pkg/services/sqlstore/org_test.go

@@ -416,7 +416,7 @@ func TestIntegrationAccountDataAccess(t *testing.T) {
 	})
 }
 
-//TODO: Use FakeDashboardStore when org has its own service
+// TODO: Use FakeDashboardStore when org has its own service
 func insertTestDashboard(t *testing.T, sqlStore *SQLStore, title string, orgId int64,
 	folderId int64, isFolder bool, tags ...interface{}) *models.Dashboard {
 	t.Helper()
@@ -473,7 +473,7 @@ func insertTestDashboard(t *testing.T, sqlStore *SQLStore, title string, orgId i
 	return dash
 }
 
-//TODO: Use FakeDashboardStore when org has its own service
+// TODO: Use FakeDashboardStore when org has its own service
 func updateDashboardACL(t *testing.T, sqlStore *SQLStore, dashboardID int64, items ...*models.DashboardACL) error {
 	t.Helper()
 

pkg/services/sqlstore/searchstore/doc.go

@@ -21,11 +21,11 @@
 //
 // Filters will be applied in order with the final result like such:
 //
-//     SELECT id FROM dashboard LEFT OUTER JOIN <FilterLeftJoin...>
-//     WHERE <FilterWhere[0]> AND ... AND <FilterWhere[n]>
-//     GROUP BY <FilterGroupBy...>
-//     ORDER BY <FilterOrderBy...>
-//     LIMIT <limit> OFFSET <(page-1)*limit>;
+//	SELECT id FROM dashboard LEFT OUTER JOIN <FilterLeftJoin...>
+//	WHERE <FilterWhere[0]> AND ... AND <FilterWhere[n]>
+//	GROUP BY <FilterGroupBy...>
+//	ORDER BY <FilterOrderBy...>
+//	LIMIT <limit> OFFSET <(page-1)*limit>;
 //
 // This structure is intended to isolate the filters from each other
 // and implementors are expected to add all the required joins, where

pkg/services/sqlstore/user.go

@@ -179,7 +179,7 @@ func (ss *SQLStore) createUser(ctx context.Context, sess *DBSession, args user.C
 	return usr, nil
 }
 
-//  deprecated method, use only for tests
+// deprecated method, use only for tests
 func (ss *SQLStore) CreateUser(ctx context.Context, cmd user.CreateUserCommand) (*user.User, error) {
 	var user user.User
 	createErr := ss.WithTransactionalDbSession(ctx, func(sess *DBSession) (err error) {