Chore: Upgrade Go to 1.19.1 (#54902)

* WIP

* Set public_suffix to a pre Ruby 2.6 version

* we don't need to install python

* Stretch->Buster

* Bump versions in lib.star

* Manually update linter

Sort of messy, but the .mod-file need to contain all dependencies that
use 1.16+ features, otherwise they're assumed to be compiled with
-lang=go1.16 and cannot access generics et al.

Bingo doesn't seem to understand that, but it's possible to manually
update things to get Bingo happy.

* undo reformatting

* Various lint improvements

* More from the linter

* goimports -w ./pkg/

* Disable gocritic

* Add/modify linter exceptions

* lint + flatten nested list

Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround.
https://go.dev/doc/comment#lists

pkg/util/cmputil/reporter.go

@@ -115,8 +115,9 @@ func describeReflectValue(v reflect.Value) interface{} {
 }
 
 // IsAddOperation returns true when
-//  - Left does not have value and Right has
-//  - the kind of Left and Right is either reflect.Slice or reflect.Map and the length of Left is less than length of Right
+//   - Left does not have value and Right has
+//   - the kind of Left and Right is either reflect.Slice or reflect.Map and the length of Left is less than length of Right
+//
 // In all other cases it returns false.
 // NOTE: this is applicable to diff of Maps and Slices only
 func (d *Diff) IsAddOperation() bool {
@@ -125,8 +126,9 @@ func (d *Diff) IsAddOperation() bool {
 }
 
 // IsDeleteOperation returns true when
-//  - Right does not have value and Left has
-//  - the kind of Left and Right is either reflect.Slice or reflect.Map and the length of Right is less than length of Left
+//   - Right does not have value and Left has
+//   - the kind of Left and Right is either reflect.Slice or reflect.Map and the length of Right is less than length of Left
+//
 // In all other cases it returns false.
 // NOTE: this is applicable to diff of Maps and Slices only
 func (d *Diff) IsDeleteOperation() bool {

pkg/util/converter/prom_test.go

@@ -45,6 +45,7 @@ func TestReadPromFrames(t *testing.T) {
 }
 
 // FIXME:
+//
 //lint:ignore U1000 Ignore used function for now
 func runScenario(name string, opts Options) func(t *testing.T) {
 	return func(t *testing.T) {

pkg/util/errutil/doc.go

@@ -26,16 +26,21 @@
 // service using the NewBase constructor with a CoreStatus and a unique
 // static message ID that identifies the general structure of the public
 // message attached to the specific error.
-//  var errNotFound = errutil.NewBase(errutil.StatusNotFound, "service.not-found")
+//
+//	var errNotFound = errutil.NewBase(errutil.StatusNotFound, "service.not-found")
+//
 // This Base can now be used to construct a regular Go error with the
 // Base.Errorf method using the same structure as fmt.Errorf:
-//  return errNotFound.Errorf("looked for thing with ID %d, but it wasn't there: %w", id, err)
+//
+//	return errNotFound.Errorf("looked for thing with ID %d, but it wasn't there: %w", id, err)
 //
 // By default, the end user will be sent the static message ID and a
 // message which is the string representation of the CoreStatus. It is
 // possible to override the message sent to the end user by using
 // the WithPublicMessage functional option when creating a new Base
-//  var errNotFound = errutil.NewBase(errutil.StatusNotFound "service.not-found", WithPublicMessage("The thing is missing."))
+//
+//	var errNotFound = errutil.NewBase(errutil.StatusNotFound "service.not-found", WithPublicMessage("The thing is missing."))
+//
 // If a dynamic message is needed, the Template type extends Base with a
 // Go template using text/template from the standard library, refer to
 // the documentation related to the Template type for usage examples.

pkg/util/errutil/errors.go

@@ -23,9 +23,10 @@ type Base struct {
 // to serve as the base for user facing error messages.
 //
 // msgID should be structured as component.error-brief, for example
-//   login.failed-authentication
-//   dashboards.validation-error
-//   dashboards.uid-already-exists
+//
+//	login.failed-authentication
+//	dashboards.validation-error
+//	dashboards.uid-already-exists
 func NewBase(reason StatusReason, msgID string, opts ...BaseOpt) Base {
 	b := Base{
 		reason:    reason,