From b28a20892656c74310489dd736dca04fe9a94baf Mon Sep 17 00:00:00 2001 From: sam boyer Date: Thu, 22 Dec 2022 03:20:25 -0500 Subject: [PATCH] kindsys: Move code ownership of CustomStructured to apps platform team (#60497) kindsys: Separate code ownership of CustomStructured --- .github/CODEOWNERS | 1 + pkg/kindsys/kindcat_custom.cue | 15 +++++++++++++++ pkg/kindsys/kindcats.cue | 8 -------- 3 files changed, 16 insertions(+), 8 deletions(-) create mode 100644 pkg/kindsys/kindcat_custom.cue diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 0940451dcef..d89b27c54ba 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -241,6 +241,7 @@ lerna.json @grafana/frontend-ops embed.go @grafana/grafana-as-code /kinds/ @grafana/grafana-as-code /pkg/codegen @grafana/grafana-as-code +/pkg/kindsys/kindcat_custom.cue @grafana/apps-platform-core /pkg/kindsys @grafana/grafana-as-code /pkg/kinds/*/*_gen.go @grafana/grafana-as-code /pkg/registry/corekind @grafana/grafana-as-code diff --git a/pkg/kindsys/kindcat_custom.cue b/pkg/kindsys/kindcat_custom.cue new file mode 100644 index 00000000000..ee159d4ed32 --- /dev/null +++ b/pkg/kindsys/kindcat_custom.cue @@ -0,0 +1,15 @@ +package kindsys + +// CustomStructured specifies the Kind category for plugin-defined arbitrary types. +// Custom kinds have the same purpose as CoreStructured kinds, differing only in +// that they are declared by external plugins rather than in Grafana core. As such, +// this specification is kept closely aligned with the CoreStructured kind. +// +// Grafana provides Kubernetes apiserver-shaped APIs for interacting with custom kinds - +// The same API patterns (and clients) used to interact with CustomResources. +#CustomStructured: { + #Structured + + lineageIsGroup: false + ... +} diff --git a/pkg/kindsys/kindcats.cue b/pkg/kindsys/kindcats.cue index 30ab638439e..3f6fe321178 100644 --- a/pkg/kindsys/kindcats.cue +++ b/pkg/kindsys/kindcats.cue @@ -120,14 +120,6 @@ _sharedKind: { // - get summary } -// TODO -#CustomStructured: { - #Structured - - lineageIsGroup: false - ... -} - // TODO #CoreStructured: { #Structured