kvstore: ensure we return notFound on delete (#107288)

* kvstore: ensure we return notFound on delete * fix tests
2025-06-27 12:00:03 +02:00
parent f1a22a8ea9
commit b2aaa9b3ce
3 changed files with 14 additions and 3 deletions
@@ -131,7 +131,16 @@ func (k *badgerKV) Delete(ctx context.Context, section string, key string) error

 	key = section + "/" + key

-	err := txn.Delete([]byte(key))
+	// Check if key exists before deleting
+	_, err := txn.Get([]byte(key))
+	if err != nil {
+		if errors.Is(err, badger.ErrKeyNotFound) {
+			return ErrNotFound
+		}
+		return err
+	}
+
+	err = txn.Delete([]byte(key))
 	if err != nil {
 		return err
 	}