public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor to prevent flakiness

Browse Source
This commit is contained in:
ivanahuckova
2025-10-13 18:17:51 +02:00
parent 4ca8ba4bf6
commit b2bd4d3e4a
1 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/core/components/AppChrome/ExtensionSidebar/ExtensionSidebarProvider.test.tsx
+15 -17
View File
@@ -1,4 +1,4 @@
import { render, screen, act } from '@testing-library/react'; import { render, screen, act, fireEvent } from '@testing-library/react';
import { store, EventBusSrv, EventBus } from '@grafana/data'; import { store, EventBusSrv, EventBus } from '@grafana/data';
import { getAppEvents, setAppEvents, locationService } from '@grafana/runtime'; import { getAppEvents, setAppEvents, locationService } from '@grafana/runtime';
@@ -395,7 +395,7 @@ describe('ExtensionSidebarProvider', () => {
expect(screen.getByTestId('docked-component-id')).toHaveTextContent(expectedComponentId); expect(screen.getByTestId('docked-component-id')).toHaveTextContent(expectedComponentId);
}); });
it('should toggle sidebar closed when receiving ToggleExtensionSidebarEvent for currently open component', () => { it('should toggle sidebar closed when receiving ToggleExtensionSidebarEvent for currently open component', async () => {
const componentId = getComponentIdFromComponentMeta(mockPluginMeta.pluginId, mockComponent); const componentId = getComponentIdFromComponentMeta(mockPluginMeta.pluginId, mockComponent);
const TestComponentWithProps = () => { const TestComponentWithProps = () => {
@@ -416,12 +416,11 @@ describe('ExtensionSidebarProvider', () => {
); );
// First open the sidebar manually // First open the sidebar manually
act(() => { screen.getByText('Open Sidebar');
screen.getByText('Open Sidebar').click(); fireEvent.click(screen.getByText('Open Sidebar'));
});
expect(screen.getByTestId('is-open')).toHaveTextContent('true'); expect(await screen.findByTestId('is-open')).toHaveTextContent('true');
expect(screen.getByTestId('docked-component-id')).toHaveTextContent(componentId); expect(await screen.findByTestId('docked-component-id')).toHaveTextContent(componentId);
act(() => { act(() => {
// Find the ToggleExtensionSidebarEvent subscriber // Find the ToggleExtensionSidebarEvent subscriber
@@ -441,11 +440,11 @@ describe('ExtensionSidebarProvider', () => {
); );
}); });
expect(screen.getByTestId('is-open')).toHaveTextContent('false'); expect(await screen.findByTestId('is-open')).toHaveTextContent('false');
expect(screen.getByTestId('docked-component-id')).toHaveTextContent('undefined'); expect(await screen.findByTestId('docked-component-id')).toHaveTextContent('undefined');
}); });
it('should toggle to different component when receiving ToggleExtensionSidebarEvent for different component', () => { it('should toggle to different component when receiving ToggleExtensionSidebarEvent for different component', async () => {
const componentId = getComponentIdFromComponentMeta(mockPluginMeta.pluginId, mockComponent); const componentId = getComponentIdFromComponentMeta(mockPluginMeta.pluginId, mockComponent);
const TestComponentWithProps = () => { const TestComponentWithProps = () => {
@@ -466,12 +465,11 @@ describe('ExtensionSidebarProvider', () => {
); );
// First open the sidebar manually // First open the sidebar manually
act(() => { screen.getByText('Open Sidebar');
screen.getByText('Open Sidebar').click(); fireEvent.click(screen.getByText('Open Sidebar'));
});
expect(screen.getByTestId('is-open')).toHaveTextContent('true'); expect(await screen.findByTestId('is-open')).toHaveTextContent('true');
expect(screen.getByTestId('docked-component-id')).toHaveTextContent(componentId); expect(await screen.findByTestId('docked-component-id')).toHaveTextContent(componentId);
act(() => { act(() => {
// Find the ToggleExtensionSidebarEvent subscriber // Find the ToggleExtensionSidebarEvent subscriber
@@ -491,12 +489,12 @@ describe('ExtensionSidebarProvider', () => {
); );
}); });
expect(screen.getByTestId('is-open')).toHaveTextContent('true'); expect(await screen.findByTestId('is-open')).toHaveTextContent('true');
const expectedComponentId = JSON.stringify({ const expectedComponentId = JSON.stringify({
pluginId: mockPluginMeta.pluginId, pluginId: mockPluginMeta.pluginId,
componentTitle: 'Different Component', componentTitle: 'Different Component',
}); });
expect(screen.getByTestId('docked-component-id')).toHaveTextContent(expectedComponentId); expect(await screen.findByTestId('docked-component-id')).toHaveTextContent(expectedComponentId);
}); });
it('should unsubscribe from all event subscriptions on unmount', () => { it('should unsubscribe from all event subscriptions on unmount', () => {