diff --git a/packages/grafana-ui/src/components/DateTimePickers/DatePickerWithInput/DatePickerWithInput.tsx b/packages/grafana-ui/src/components/DateTimePickers/DatePickerWithInput/DatePickerWithInput.tsx index dc34ddc5a45..ea76baa8bab 100644 --- a/packages/grafana-ui/src/components/DateTimePickers/DatePickerWithInput/DatePickerWithInput.tsx +++ b/packages/grafana-ui/src/components/DateTimePickers/DatePickerWithInput/DatePickerWithInput.tsx @@ -1,11 +1,11 @@ import React, { ChangeEvent } from 'react'; import { css } from '@emotion/css'; -import { dateTime, dateTimeFormat } from '@grafana/data'; +import { dateTime } from '@grafana/data'; import { DatePicker } from '../DatePicker/DatePicker'; import { Props as InputProps, Input } from '../../Input/Input'; import { useStyles } from '../../../themes'; -export const formatDate = (date: Date | string) => dateTimeFormat(date, { format: 'L' }); +export const formatDate = (date: Date | string) => dateTime(date).format('L'); /** @public */ export interface DatePickerWithInputProps extends Omit { diff --git a/packages/grafana-ui/src/components/Segment/SegmentAsync.tsx b/packages/grafana-ui/src/components/Segment/SegmentAsync.tsx index 67093f43ce4..b952c38367e 100644 --- a/packages/grafana-ui/src/components/Segment/SegmentAsync.tsx +++ b/packages/grafana-ui/src/components/Segment/SegmentAsync.tsx @@ -13,8 +13,10 @@ import { useStyles } from '../../themes'; export interface SegmentAsyncProps extends SegmentProps, Omit, 'value' | 'onChange'> { value?: T | SelectableValue; loadOptions: (query?: string) => Promise>>; - // if true, options will be reloaded when user changes the value in the input, - // otherwise, options will be loaded when the segment is clicked + /** + * If true options will be reloaded when user changes the value in the input, + * otherwise, options will be loaded when the segment is clicked + */ reloadOptionsOnChange?: boolean; onChange: (item: SelectableValue) => void; noOptionMessageHandler?: (state: AsyncState>>) => string; diff --git a/packages/grafana-ui/src/components/Segment/SegmentSelect.tsx b/packages/grafana-ui/src/components/Segment/SegmentSelect.tsx index fe84a6c62a1..a50d59b4285 100644 --- a/packages/grafana-ui/src/components/Segment/SegmentSelect.tsx +++ b/packages/grafana-ui/src/components/Segment/SegmentSelect.tsx @@ -11,7 +11,9 @@ export interface Props extends Omit, 'value' | 'onC value?: SelectableValue; options: Array>; onChange: (item: SelectableValue) => void; - // if provided - AsyncSelect will be used allowing to reload options when the value in the input changes + /** + * If provided - AsyncSelect will be used allowing to reload options when the value in the input changes + */ loadOptions?: (inputValue: string) => Promise>>; onClickOutside: () => void; width: number; diff --git a/public/app/plugins/datasource/graphite/components/TagsSection.tsx b/public/app/plugins/datasource/graphite/components/TagsSection.tsx index c71942bf92f..01c76735639 100644 --- a/public/app/plugins/datasource/graphite/components/TagsSection.tsx +++ b/public/app/plugins/datasource/graphite/components/TagsSection.tsx @@ -34,8 +34,8 @@ export function TagsSection({ tags, state, addTagSegments }: Props) { // Options are reloaded while user is typing with backend taking care of auto-complete (auto-complete cannot be // implemented in front-end because backend returns only limited number of entries) const getTagsAsSegmentsOptions = useCallback( - (inputValue: string) => { - return getTagsAsSegmentsSelectables(state, inputValue); + (inputValue?: string) => { + return getTagsAsSegmentsSelectables(state, inputValue || ''); }, [state] );