From b47f8e21f5ed72305246e0eced02d5d80d277211 Mon Sep 17 00:00:00 2001 From: "Tania B." <10127682+undef1nd@users.noreply.github.com> Date: Thu, 18 Dec 2025 15:48:45 +0100 Subject: [PATCH] Migrate logRequestsInstrumentedAsUnknown flag to OpenFeature --- pkg/middleware/request_metrics.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/middleware/request_metrics.go b/pkg/middleware/request_metrics.go index 9e32b75f7c9..92875b401bf 100644 --- a/pkg/middleware/request_metrics.go +++ b/pkg/middleware/request_metrics.go @@ -6,6 +6,7 @@ import ( "strings" "time" + "github.com/open-feature/go-sdk/openfeature" "github.com/prometheus/client_golang/prometheus" "github.com/grafana/grafana/pkg/infra/log" @@ -114,8 +115,12 @@ func RequestMetrics(features featuremgmt.FeatureToggles, cfg *setting.Cfg, promR handler = "notfound" } else { // log requests where we could not identify handler so we can register them. - //nolint:staticcheck // not yet migrated to OpenFeature - if features.IsEnabled(r.Context(), featuremgmt.FlagLogRequestsInstrumentedAsUnknown) { + evalCtx := openfeature.TransactionContext(r.Context()) + flag, err := openfeature.NewDefaultClient().BooleanValueDetails(r.Context(), featuremgmt.FlagLogRequestsInstrumentedAsUnknown, false, evalCtx) + if err != nil { + log.Error("failed to evaluate feature flag: %w", err) + } + if flag.Value { log.Warn("request instrumented as unknown", "path", r.URL.Path, "status_code", status) } }