public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Select: Ensure screenreader correctly narrates options (#88118)

Browse Source 
* replace select aria-label with data-testid

* update in copy pasted places as well

* update plugin-e2e to 1.2.2
This commit is contained in:
Ashley Harrison
2024-05-28 14:51:47 +01:00
committed by GitHub
parent 6205236f25
commit b4e49e3114
21 changed files with 60 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/various-suite/prometheus-config.spec.ts
+1 -1
View File
@@ -107,5 +107,5 @@ describe('Prometheus config', () => {
});
export function selectOption(option: string) {
cy.get("[aria-label='Select option']").contains(option).should('be.visible').click();
e2e.components.Select.option().contains(option).should('be.visible').click();
}
e2e/various-suite/prometheus-editor.spec.ts
+1 -1
View File
@@ -178,5 +178,5 @@ describe('Prometheus query editor', () => {
});
function selectOption(option: string) {
cy.get("[aria-label='Select option']").contains(option).should('be.visible').click();
e2e.components.Select.option().contains(option).should('be.visible').click();
}
e2e/various-suite/prometheus-variable-editor.spec.ts
+1 -1
View File
@@ -118,5 +118,5 @@ describe('Prometheus variable query editor', () => {
});
function selectOption(option: string) {
cy.get("[aria-label='Select option']").contains(option).should('be.visible').click();
e2e.components.Select.option().contains(option).should('be.visible').click();
}