From b5337ba419ca3502c1a56fdb5898d26e364ef788 Mon Sep 17 00:00:00 2001
From: Josh Hunt <joshhunt@users.noreply.github.com>
Date: Tue, 16 Apr 2024 10:28:24 +0100
Subject: [PATCH] I18N: Fix untranslated descriptions in data source picker
 (#86216)

I18n: Remove t() call from root module scope
---
 .../picker/BuiltInDataSourceList.tsx          | 25 ++++++++++++-------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx b/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx
index 44c90bf819c..513c33e0027 100644
--- a/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx
+++ b/public/app/features/datasources/components/picker/BuiltInDataSourceList.tsx
@@ -10,14 +10,21 @@ import { useDatasources } from '../../hooks';
 import { DataSourceCard } from './DataSourceCard';
 import { isDataSourceMatch } from './utils';
 
-const CUSTOM_DESCRIPTIONS_BY_UID: Record<string, string> = {
-  grafana: t('data-source-picker.built-in-list.description-grafana', 'Discover visualizations using mock data'),
-  '-- Mixed --': t('data-source-picker.built-in-list.description-mixed', 'Use multiple data sources'),
-  '-- Dashboard --': t(
-    'data-source-picker.built-in-list.description-dashboard',
-    'Reuse query results from other visualizations'
-  ),
-};
+function getCustomDescription(datasourceUid: string) {
+  switch (datasourceUid) {
+    case 'grafana':
+      return t('data-source-picker.built-in-list.description-grafana', 'Discover visualizations using mock data');
+    case '-- Mixed --':
+      return t('data-source-picker.built-in-list.description-mixed', 'Use multiple data sources');
+    case '-- Dashboard --':
+      return t(
+        'data-source-picker.built-in-list.description-dashboard',
+        'Reuse query results from other visualizations'
+      );
+    default:
+      return '';
+  }
+}
 
 interface BuiltInDataSourceListProps {
   className?: string;
@@ -76,7 +83,7 @@ export function BuiltInDataSourceList({
           <DataSourceCard
             key={ds.uid}
             ds={ds}
-            description={CUSTOM_DESCRIPTIONS_BY_UID[ds.uid]}
+            description={getCustomDescription(ds.uid)}
             selected={isDataSourceMatch(ds, current)}
             onClick={() => onChange(ds)}
           />