Chore: Remove dashboards from models pkg (#61578)

* Copy dashboard models to dashboard pkg

* Use some models from current pkg instead of models

* Adjust api pkg

* Adjust pkg services

* Fix lint

* Chore: Remove dashboards models

* Remove dashboards from models pkg

* Fix lint in tests

* Fix lint in tests 2

* Fix for import in auth

* Remove newline

* Revert unused fix

pkg/services/sqlstore/migrations/ualert/migration_test.go

@@ -15,6 +15,7 @@ import (
 
 	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/models"
+	"github.com/grafana/grafana/pkg/services/dashboards"
 	"github.com/grafana/grafana/pkg/services/datasources"
 	ngModels "github.com/grafana/grafana/pkg/services/ngalert/models"
 	"github.com/grafana/grafana/pkg/services/org"
@@ -671,12 +672,12 @@ func createAlert(t *testing.T, orgId int64, dashboardId int64, panelsId int64, n
 }
 
 // createDashboard creates a dashboard for inserting into the test database.
-func createDashboard(t *testing.T, id int64, orgId int64, uid string) *models.Dashboard {
+func createDashboard(t *testing.T, id int64, orgId int64, uid string) *dashboards.Dashboard {
 	t.Helper()
-	return &models.Dashboard{
-		Id:      id,
-		OrgId:   orgId,
-		Uid:     uid,
+	return &dashboards.Dashboard{
+		ID:      id,
+		OrgID:   orgId,
+		UID:     uid,
 		Created: now,
 		Updated: now,
 		Title:   uid, // Not tested, needed to satisfy contraint.
@@ -744,7 +745,7 @@ func setupLegacyAlertsTables(t *testing.T, x *xorm.Engine, legacyChannels []*mod
 	}
 
 	// Setup dashboards.
-	dashboards := []models.Dashboard{
+	dashboards := []dashboards.Dashboard{
 		*createDashboard(t, 1, 1, "dash1-1"),
 		*createDashboard(t, 2, 1, "dash2-1"),
 		*createDashboard(t, 3, 2, "dash3-2"),

pkg/services/sqlstore/migrations/ualert/permissions.go

@@ -144,7 +144,7 @@ func (m *folderHelper) generateNewDashboardUid(orgId int64) (string, error) {
 	for i := 0; i < 3; i++ {
 		uid := util.GenerateShortUID()
 
-		exists, err := m.sess.Where("org_id=? AND uid=?", orgId, uid).Get(&models.Dashboard{})
+		exists, err := m.sess.Where("org_id=? AND uid=?", orgId, uid).Get(&dashboards.Dashboard{})
 		if err != nil {
 			return "", err
 		}
@@ -252,7 +252,7 @@ func (m *folderHelper) setACL(orgID int64, dashboardID int64, items []*dashboard
 	}
 
 	// Update dashboard HasACL flag
-	dashboard := models.Dashboard{HasACL: true}
+	dashboard := dashboards.Dashboard{HasACL: true}
 	_, err := m.sess.Cols("has_acl").Where("id=?", dashboardID).Update(&dashboard)
 	return err
 }