From b58f7741b52fd6a00a462b842c76c682d0774d87 Mon Sep 17 00:00:00 2001 From: Marcus Efraimsson Date: Fri, 12 Jun 2020 16:04:09 +0200 Subject: [PATCH] InfluxDB: Fix invalid memory address or nil pointer dereference when schema is missing in URL (#25565) Add guard if parsing url fails in influxdb backend data source. Fixes #25242 (cherry picked from commit bd8a04a6a573e450d1feb57dff76a9f0f58d2f1f) --- pkg/tsdb/influxdb/influxdb.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/tsdb/influxdb/influxdb.go b/pkg/tsdb/influxdb/influxdb.go index 3b8f365211a..8a1049b49f6 100644 --- a/pkg/tsdb/influxdb/influxdb.go +++ b/pkg/tsdb/influxdb/influxdb.go @@ -113,7 +113,10 @@ func (e *InfluxDBExecutor) getQuery(dsInfo *models.DataSource, queries []*tsdb.Q func (e *InfluxDBExecutor) createRequest(dsInfo *models.DataSource, query string) (*http.Request, error) { - u, _ := url.Parse(dsInfo.Url) + u, err := url.Parse(dsInfo.Url) + if err != nil { + return nil, err + } u.Path = path.Join(u.Path, "query") httpMode := dsInfo.JsonData.Get("httpMode").MustString("GET")