From b5d3b5d2b0e915a510a5cf044177e57277669ce2 Mon Sep 17 00:00:00 2001 From: ismail simsek Date: Wed, 28 May 2025 21:19:53 +0200 Subject: [PATCH] Revert "always return data" This reverts commit 38e493c189d627ee7fd1ef9b551059ea64d6eff0. --- packages/grafana-prometheus/src/language_provider.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/grafana-prometheus/src/language_provider.ts b/packages/grafana-prometheus/src/language_provider.ts index c51604ad449..794dab5b362 100644 --- a/packages/grafana-prometheus/src/language_provider.ts +++ b/packages/grafana-prometheus/src/language_provider.ts @@ -516,7 +516,7 @@ export default class PromQlLanguageProvider extends LanguageProvider implements export interface PrometheusLanguageProviderInterface extends PrometheusBaseLanguageProvider, PrometheusLegacyLanguageProvider { - retrieveMetricsMetadata: () => PromMetricsMetadata; + retrieveMetricsMetadata: () => PromMetricsMetadata | undefined; retrieveHistogramMetrics: () => string[]; retrieveMetrics: () => string[]; retrieveLabelKeys: () => string[]; @@ -584,8 +584,8 @@ export class PrometheusLanguageProvider extends PromQlLanguageProvider implement return fixSummariesMetadata(metadata); }; - public retrieveMetricsMetadata = (): PromMetricsMetadata => { - return this._metricsMetadata ?? {}; + public retrieveMetricsMetadata = (): PromMetricsMetadata | undefined => { + return this._metricsMetadata; }; public retrieveHistogramMetrics = (): string[] => { @@ -601,7 +601,7 @@ export class PrometheusLanguageProvider extends PromQlLanguageProvider implement }; public queryMetricsMetadata = async (): Promise => { - this._metricsMetadata = (await this._queryMetadata()) ?? {}; + this._metricsMetadata = await this._queryMetadata(); return this._metricsMetadata; };