Migrate wrong datasource UIDs (#86598)

pkg/services/datasources/service/store_test.go

@@ -11,8 +11,10 @@ import (
 
 	"github.com/grafana/grafana/pkg/events"
 	"github.com/grafana/grafana/pkg/infra/db"
+	"github.com/grafana/grafana/pkg/infra/log"
 	ac "github.com/grafana/grafana/pkg/services/accesscontrol"
 	"github.com/grafana/grafana/pkg/services/datasources"
+	"github.com/grafana/grafana/pkg/services/featuremgmt"
 )
 
 func TestIntegrationDataAccess(t *testing.T) {
@@ -96,6 +98,19 @@ func TestIntegrationDataAccess(t *testing.T) {
 			require.IsType(t, datasources.ErrDataSourceUidExists, err)
 		})
 
+		t.Run("fails to create a datasource with an invalid uid", func(t *testing.T) {
+			db := db.InitTestDB(t)
+			ss := SqlStore{
+				db:       db,
+				logger:   log.NewNopLogger(),
+				features: featuremgmt.WithFeatures(featuremgmt.FlagAutofixDSUID),
+			}
+			cmd := defaultAddDatasourceCommand
+			cmd.UID = "test/uid"
+			_, err := ss.AddDataSource(context.Background(), &cmd)
+			require.ErrorContains(t, err, "invalid format of UID")
+		})
+
 		t.Run("fires an event when the datasource is added", func(t *testing.T) {
 			db := db.InitTestDB(t)
 			sqlStore := SqlStore{db: db}
@@ -213,6 +228,30 @@ func TestIntegrationDataAccess(t *testing.T) {
 			_, err := ss.UpdateDataSource(context.Background(), cmd)
 			require.NoError(t, err)
 		})
+
+		t.Run("updates UID with a valid one", func(t *testing.T) {
+			db := db.InitTestDB(t)
+			ds := initDatasource(db)
+			ss := SqlStore{
+				db:       db,
+				logger:   log.NewNopLogger(),
+				features: featuremgmt.WithFeatures(featuremgmt.FlagAutofixDSUID),
+			}
+			require.NotEmpty(t, ds.UID)
+
+			cmd := defaultUpdateDatasourceCommand
+			cmd.ID = ds.ID
+			cmd.UID = "new/uid"
+			res, err := ss.UpdateDataSource(context.Background(), &cmd)
+			require.NoError(t, err)
+			require.Equal(t, "new-uid", res.UID)
+
+			// Return the datasource with the valid UID
+			query := datasources.GetDataSourceQuery{UID: "new-uid", OrgID: 10}
+			dataSource, err := ss.GetDataSource(context.Background(), &query)
+			require.NoError(t, err)
+			require.Equal(t, "new-uid", dataSource.UID)
+		})
 	})
 
 	t.Run("DeleteDataSourceById", func(t *testing.T) {