diff --git a/pkg/services/ngalert/notifier/channels/alertmanager_test.go b/pkg/services/ngalert/notifier/channels/alertmanager_test.go index dfd27ff5196..35bd4ae1c7a 100644 --- a/pkg/services/ngalert/notifier/channels/alertmanager_test.go +++ b/pkg/services/ngalert/notifier/channels/alertmanager_test.go @@ -9,7 +9,7 @@ import ( "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/infra/log" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" + "github.com/grafana/grafana/pkg/services/secrets/fakes" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" @@ -55,7 +55,7 @@ func TestNewAlertmanagerNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue sn, err := NewAlertmanagerNotifier(m, tmpl, decryptFn) if c.expectedInitError != "" { @@ -136,7 +136,7 @@ func TestAlertmanagerNotifier_Notify(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue sn, err := NewAlertmanagerNotifier(m, tmpl, decryptFn) require.NoError(t, err) diff --git a/pkg/services/ngalert/notifier/channels/line_test.go b/pkg/services/ngalert/notifier/channels/line_test.go index d17caf1f016..a6a4a98f85d 100644 --- a/pkg/services/ngalert/notifier/channels/line_test.go +++ b/pkg/services/ngalert/notifier/channels/line_test.go @@ -5,6 +5,8 @@ import ( "net/url" "testing" + "github.com/grafana/grafana/pkg/services/secrets/fakes" + "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -13,7 +15,6 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" ) func TestLineNotifier(t *testing.T) { @@ -89,7 +90,7 @@ func TestLineNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewLineNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/opsgenie_test.go b/pkg/services/ngalert/notifier/channels/opsgenie_test.go index 9292ca1a2f7..51ad5265076 100644 --- a/pkg/services/ngalert/notifier/channels/opsgenie_test.go +++ b/pkg/services/ngalert/notifier/channels/opsgenie_test.go @@ -6,6 +6,7 @@ import ( "testing" "time" + "github.com/grafana/grafana/pkg/services/secrets/fakes" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -14,7 +15,6 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" ) func TestOpsgenieNotifier(t *testing.T) { @@ -169,7 +169,7 @@ func TestOpsgenieNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewOpsgenieNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/pagerduty_test.go b/pkg/services/ngalert/notifier/channels/pagerduty_test.go index 82c82ad5af8..013631521e2 100644 --- a/pkg/services/ngalert/notifier/channels/pagerduty_test.go +++ b/pkg/services/ngalert/notifier/channels/pagerduty_test.go @@ -7,6 +7,7 @@ import ( "os" "testing" + "github.com/grafana/grafana/pkg/services/secrets/fakes" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -15,7 +16,6 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" ) func TestPagerdutyNotifier(t *testing.T) { @@ -135,7 +135,7 @@ func TestPagerdutyNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewPagerdutyNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/pushover_test.go b/pkg/services/ngalert/notifier/channels/pushover_test.go index 6bf0e400c59..9ba06dfb88b 100644 --- a/pkg/services/ngalert/notifier/channels/pushover_test.go +++ b/pkg/services/ngalert/notifier/channels/pushover_test.go @@ -14,7 +14,7 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" + "github.com/grafana/grafana/pkg/services/secrets/fakes" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -142,7 +142,7 @@ func TestPushoverNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewPushoverNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/sensugo_test.go b/pkg/services/ngalert/notifier/channels/sensugo_test.go index 6bcb8a5e33c..52edb4a1307 100644 --- a/pkg/services/ngalert/notifier/channels/sensugo_test.go +++ b/pkg/services/ngalert/notifier/channels/sensugo_test.go @@ -10,8 +10,7 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" - + "github.com/grafana/grafana/pkg/services/secrets/fakes" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -140,7 +139,7 @@ func TestSensuGoNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue sn, err := NewSensuGoNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/slack_test.go b/pkg/services/ngalert/notifier/channels/slack_test.go index 2cff57f37ea..00b94f5146d 100644 --- a/pkg/services/ngalert/notifier/channels/slack_test.go +++ b/pkg/services/ngalert/notifier/channels/slack_test.go @@ -11,8 +11,7 @@ import ( "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/infra/log" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" - + "github.com/grafana/grafana/pkg/services/secrets/fakes" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -171,7 +170,7 @@ func TestSlackNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewSlackNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/telegram_test.go b/pkg/services/ngalert/notifier/channels/telegram_test.go index 69f6125dc1e..ab31eb69ba6 100644 --- a/pkg/services/ngalert/notifier/channels/telegram_test.go +++ b/pkg/services/ngalert/notifier/channels/telegram_test.go @@ -5,9 +5,9 @@ import ( "net/url" "testing" - "github.com/grafana/grafana/pkg/components/simplejson" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" + "github.com/grafana/grafana/pkg/services/secrets/fakes" + "github.com/grafana/grafana/pkg/components/simplejson" "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -95,7 +95,7 @@ func TestTelegramNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewTelegramNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/threema_test.go b/pkg/services/ngalert/notifier/channels/threema_test.go index f0acfe300ae..77cf0972e7c 100644 --- a/pkg/services/ngalert/notifier/channels/threema_test.go +++ b/pkg/services/ngalert/notifier/channels/threema_test.go @@ -5,6 +5,8 @@ import ( "net/url" "testing" + "github.com/grafana/grafana/pkg/services/secrets/fakes" + "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/types" "github.com/prometheus/common/model" @@ -13,7 +15,6 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" ) func TestThreemaNotifier(t *testing.T) { @@ -107,7 +108,7 @@ func TestThreemaNotifier(t *testing.T) { Settings: settingsJSON, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewThreemaNotifier(m, tmpl, decryptFn) if c.expInitError != "" { diff --git a/pkg/services/ngalert/notifier/channels/webhook_test.go b/pkg/services/ngalert/notifier/channels/webhook_test.go index 5bdf8f1b407..45d4e2bcfd5 100644 --- a/pkg/services/ngalert/notifier/channels/webhook_test.go +++ b/pkg/services/ngalert/notifier/channels/webhook_test.go @@ -6,6 +6,8 @@ import ( "net/url" "testing" + "github.com/grafana/grafana/pkg/services/secrets/fakes" + "github.com/prometheus/alertmanager/notify" "github.com/prometheus/alertmanager/template" "github.com/prometheus/alertmanager/types" @@ -15,7 +17,6 @@ import ( "github.com/grafana/grafana/pkg/bus" "github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/models" - secretsManager "github.com/grafana/grafana/pkg/services/secrets/manager" ) func TestWebhookNotifier(t *testing.T) { @@ -189,7 +190,7 @@ func TestWebhookNotifier(t *testing.T) { OrgID: orgID, } - secretsService := secretsManager.SetupTestService(t, nil) + secretsService := fakes.NewFakeSecretsService() decryptFn := secretsService.GetDecryptedValue pn, err := NewWebHookNotifier(m, tmpl, decryptFn) if c.expInitError != "" {