Provisioning: Fix race condition causing unhealthy repository message to be lost (#115150)

* Fix race condition causing unhealthy repository message to be lost

This commit fixes a race condition in the provisioning repository controller
where the "Repository is unhealthy" message in the sync status could be lost
due to status updates being based on stale repository objects.

## Problem

The issue occurred in the `process` function when:
1. Repository object was fetched from cache with old status
2. `RefreshHealth` immediately patched the health status to "unhealthy"
3. `determineSyncStatusOps` used the stale object to check if unhealthy
   message was already set
4. A second patch operation based on stale data would overwrite the
   health status update

## Solution

Introduced `RefreshHealthWithPatchOps` method that returns patch operations
instead of immediately applying them. This allows batching all status updates
(health + sync) into a single atomic patch operation, eliminating the race
condition.

## Changes

- Added `HealthCheckerInterface` for better testability
- Added `RefreshHealthWithPatchOps` method to return patch ops without applying
- Updated `process` function to batch health and sync status updates
- Added comprehensive unit tests for the fix

Fixes the issue where unhealthy repositories don't show the "Repository is
unhealthy" message in their sync status.

* Fix staticcheck lint error: remove unnecessary nil check for slice

This commit is contained in:

Roberto Jiménez Sánchez

2025-12-12 13:24:58 +02:00

committed by

GitHub

parent c7c052480d

commit b863acab05

6 changed files with 518 additions and 2 deletions

									
										pkg/registry/apis/provisioning/controller/mocks/StatusPatcher.go
									
		+1
		-1
	
												View File
												
				@@ -1,4 +1,4 @@

				// Code generated by mockery v2.52.4. DO NOT EDIT.

				// Code generated by mockery v2.53.4. DO NOT EDIT.

				package mocks