Chore: remove scenario wrapping in cypress tests (#74674)

* remove scenario wrapping in cypress tests

* remove more hardcoded logins

* don't forget the various suite!

* make sure we log in for every test

* fix afterAll revert

* stability

e2e/utils/support/localStorage.ts

@@ -1,5 +1,3 @@
-import { e2e } from '../index';
-
 // @todo this actually returns type `Cypress.Chainable`
 const get = (key: string): any =>
   cy.wrap({ getLocalStorage: () => localStorage.getItem(key) }, { log: false }).invoke('getLocalStorage');

e2e/utils/support/scenario.ts

@@ -1,53 +0,0 @@
-import { e2e } from '../';
-
-export interface ScenarioArguments {
-  describeName: string;
-  itName: string;
-  scenario: Function;
-  skipScenario?: boolean;
-  addScenarioDataSource?: boolean;
-  addScenarioDashBoard?: boolean;
-  loginViaApi?: boolean;
-}
-
-export const e2eScenario = ({
-  describeName,
-  itName,
-  scenario,
-  skipScenario = false,
-  addScenarioDataSource = false,
-  addScenarioDashBoard = false,
-  loginViaApi = true,
-}: ScenarioArguments) => {
-  describe(describeName, () => {
-    if (skipScenario) {
-      it.skip(itName, () => scenario());
-    } else {
-      before(() => {
-        cy.session(
-          'login',
-          () => {
-            e2e.flows.login(e2e.env('USERNAME'), e2e.env('PASSWORD'), loginViaApi);
-          },
-          {
-            cacheAcrossSpecs: true,
-          }
-        );
-        e2e.flows.setDefaultUserPreferences();
-      });
-
-      beforeEach(() => {
-        if (addScenarioDataSource) {
-          e2e.flows.addDataSource();
-        }
-        if (addScenarioDashBoard) {
-          e2e.flows.addDashboard();
-        }
-      });
-
-      afterEach(() => e2e.flows.revertAllChanges());
-
-      it(itName, () => scenario());
-    }
-  });
-};

e2e/utils/support/scenarioContext.ts

@@ -1,6 +1,5 @@
 import { DeleteDashboardConfig } from '../flows/deleteDashboard';
 import { DeleteDataSourceConfig } from '../flows/deleteDataSource';
-import { e2e } from '../index';
 
 export interface ScenarioContext {
   addedDashboards: DeleteDashboardConfig[];