CloudWatch: Add support for AWS Metric Insights (#42487)

* add support for code editor and builder * refactor cloudwatch migration * Add tooltip to editor field (#56) * add tooltip * add old tooltips * Bug bash feedback fixes (#58) * make ASC the default option * update sql preview whenever sql changes * don't allow queries without aggregation * set default value for aggregation * use new input field * cleanup * pr feedback * prevent unnecessary rerenders * use frame error instead of main error * remove not used snapshot * Use dimension filter in schema picker (#63) * use dimension key filter in group by and schema labels * add dimension filter also to code editor * add tests * fix build error * fix strict error * remove debug code * fix annotation editor (#64) * fix annotation editor * fix broken test * revert annotation backend change * PR feedback (#67) * pr feedback * removed dimension filter from group by * add spacing between common fields and rest * do not generate deep link for metric queries (#70) * update docs (#69) Co-authored-by: Erik Sundell <erik.sundell87@gmail.com> * fix lint problem caused by merge conflict Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
2021-11-30 10:53:31 +01:00
parent 2a50c029b2
commit bab78a9e64
86 changed files with 6487 additions and 1010 deletions
@@ -272,4 +272,54 @@ func TestRequestParser(t *testing.T) {
 			assert.Equal(t, 21600, res.Period)
 		})
 	})
+
+	t.Run("Metric query type, metric editor mode and query api mode", func(t *testing.T) {
+		timeRange := legacydata.NewDataTimeRange("now-1h", "now-2h")
+		from, err := timeRange.ParseFrom()
+		require.NoError(t, err)
+		to, err := timeRange.ParseTo()
+		require.NoError(t, err)
+
+		t.Run("when metric query type and metric editor mode is not specified", func(t *testing.T) {
+			t.Run("it should be metric search builder", func(t *testing.T) {
+				query := getBaseJsonQuery()
+				res, err := parseRequestQuery(query, "ref1", from, to)
+				require.NoError(t, err)
+				assert.Equal(t, MetricQueryTypeSearch, res.MetricQueryType)
+				assert.Equal(t, MetricEditorModeBuilder, res.MetricEditorMode)
+				assert.Equal(t, GMDApiModeMetricStat, res.getGMDAPIMode())
+			})
+
+			t.Run("and an expression is specified it should be metric search builder", func(t *testing.T) {
+				query := getBaseJsonQuery()
+				query.Set("expression", "SUM(a)")
+				res, err := parseRequestQuery(query, "ref1", from, to)
+				require.NoError(t, err)
+				assert.Equal(t, MetricQueryTypeSearch, res.MetricQueryType)
+				assert.Equal(t, MetricEditorModeRaw, res.MetricEditorMode)
+				assert.Equal(t, GMDApiModeMathExpression, res.getGMDAPIMode())
+			})
+		})
+
+		t.Run("and an expression is specified it should be metric search builder", func(t *testing.T) {
+			query := getBaseJsonQuery()
+			query.Set("expression", "SUM(a)")
+			res, err := parseRequestQuery(query, "ref1", from, to)
+			require.NoError(t, err)
+			assert.Equal(t, MetricQueryTypeSearch, res.MetricQueryType)
+			assert.Equal(t, MetricEditorModeRaw, res.MetricEditorMode)
+			assert.Equal(t, GMDApiModeMathExpression, res.getGMDAPIMode())
+		})
+	})
+}
+
+func getBaseJsonQuery() *simplejson.Json {
+	return simplejson.NewFromAny(map[string]interface{}{
+		"refId":      "ref1",
+		"region":     "us-east-1",
+		"namespace":  "ec2",
+		"metricName": "CPUUtilization",
+		"statistic":  "Average",
+		"period":     "900",
+	})
 }