From bafb69d8771c982f3cb369516e8ec493fb525b29 Mon Sep 17 00:00:00 2001 From: Juan Cabanas Date: Mon, 23 Sep 2024 13:28:48 +0200 Subject: [PATCH] ShareDrawer: GA enablement (#93344) --- .../configure-grafana/feature-toggles/index.md | 2 +- pkg/services/featuremgmt/registry.go | 3 ++- pkg/services/featuremgmt/toggles_gen.csv | 2 +- pkg/services/featuremgmt/toggles_gen.json | 12 ++++++++---- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md index 8f7c75bbe0e..70241e18f24 100644 --- a/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md +++ b/docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md @@ -67,6 +67,7 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general- | `groupToNestedTableTransformation` | Enables the group to nested table transformation | Yes | | `tlsMemcached` | Use TLS-enabled memcached in the enterprise caching feature | Yes | | `cloudWatchNewLabelParsing` | Updates CloudWatch label parsing to be more accurate | Yes | +| `newDashboardSharingComponent` | Enables the new sharing drawer design | | | `pluginProxyPreserveTrailingSlash` | Preserve plugin proxy trailing slash. | | | `openSearchBackendFlowEnabled` | Enables the backend query flow for Open Search datasource plugin | Yes | | `cloudWatchRoundUpEndTime` | Round up end time for metric queries to the next minute to avoid missing data | Yes | @@ -184,7 +185,6 @@ Experimental features might be changed or removed without prior notice. | `disableNumericMetricsSortingInExpressions` | In server-side expressions, disable the sorting of numeric-kind metrics by their metric name or labels. | | `queryLibrary` | Enables Query Library feature in Explore | | `logsExploreTableDefaultVisualization` | Sets the logs table as default visualisation in logs explore | -| `newDashboardSharingComponent` | Enables the new sharing drawer design | | `alertingListViewV2` | Enables the new alert list view design | | `notificationBanner` | Enables the notification banner UI and API | | `dashboardRestore` | Enables deleted dashboard restore feature (backend only) | diff --git a/pkg/services/featuremgmt/registry.go b/pkg/services/featuremgmt/registry.go index 31d2b3d1f59..783bb2f8aa0 100644 --- a/pkg/services/featuremgmt/registry.go +++ b/pkg/services/featuremgmt/registry.go @@ -1218,9 +1218,10 @@ var ( { Name: "newDashboardSharingComponent", Description: "Enables the new sharing drawer design", - Stage: FeatureStageExperimental, + Stage: FeatureStageGeneralAvailability, Owner: grafanaSharingSquad, FrontendOnly: true, + Expression: "false", // disabled by default }, { Name: "alertingListViewV2", diff --git a/pkg/services/featuremgmt/toggles_gen.csv b/pkg/services/featuremgmt/toggles_gen.csv index 8b0fd011d25..a2d6581e3f1 100644 --- a/pkg/services/featuremgmt/toggles_gen.csv +++ b/pkg/services/featuremgmt/toggles_gen.csv @@ -159,7 +159,7 @@ disableNumericMetricsSortingInExpressions,experimental,@grafana/observability-me grafanaManagedRecordingRules,experimental,@grafana/alerting-squad,false,false,false queryLibrary,experimental,@grafana/explore-squad,false,false,false logsExploreTableDefaultVisualization,experimental,@grafana/observability-logs,false,false,true -newDashboardSharingComponent,experimental,@grafana/sharing-squad,false,false,true +newDashboardSharingComponent,GA,@grafana/sharing-squad,false,false,true alertingListViewV2,experimental,@grafana/alerting-squad,false,false,true notificationBanner,experimental,@grafana/grafana-frontend-platform,false,false,false dashboardRestore,experimental,@grafana/search-and-storage,false,false,false diff --git a/pkg/services/featuremgmt/toggles_gen.json b/pkg/services/featuremgmt/toggles_gen.json index 4969a5c5bed..036c2eaa02a 100644 --- a/pkg/services/featuremgmt/toggles_gen.json +++ b/pkg/services/featuremgmt/toggles_gen.json @@ -1964,14 +1964,18 @@ { "metadata": { "name": "newDashboardSharingComponent", - "resourceVersion": "1718727528075", - "creationTimestamp": "2024-05-03T15:02:18Z" + "resourceVersion": "1726241874335", + "creationTimestamp": "2024-05-03T15:02:18Z", + "annotations": { + "grafana.app/updatedTimestamp": "2024-09-13 15:37:54.335099 +0000 UTC" + } }, "spec": { "description": "Enables the new sharing drawer design", - "stage": "experimental", + "stage": "GA", "codeowner": "@grafana/sharing-squad", - "frontend": true + "frontend": true, + "expression": "false" } }, {