From bb17193ce5aebcfc19cc46322f7f1468abe8380f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hugo=20H=C3=A4ggmark?= <hugo.haggmark@grafana.com>
Date: Wed, 8 Dec 2021 10:11:01 +0100
Subject: [PATCH] Variables: Adds user interaction reports (#42802)

* Variables: Adds user interaction reports

* Chore: updates after PR feedback
---
 .../DashboardSettings/DashboardSettings.tsx          |  9 ++++++---
 .../features/variables/editor/VariableEditorList.tsx |  2 ++
 .../variables/editor/VariableEditorListRow.tsx       |  3 +++
 .../variables/inspect/VariableUsagesButton.tsx       | 12 +++++++++++-
 .../inspect/VariablesDependenciesButton.tsx          | 12 ++++++++++--
 5 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx b/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx
index 757ae1a4491..dd8d6763e86 100644
--- a/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx
+++ b/public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx
@@ -6,7 +6,7 @@ import config from 'app/core/config';
 import { contextSrv } from 'app/core/services/context_srv';
 import { dashboardWatcher } from 'app/features/live/dashboard/dashboardWatcher';
 import { DashboardModel } from '../../state/DashboardModel';
-import { SaveDashboardButton, SaveDashboardAsButton } from '../SaveDashboard/SaveDashboardButton';
+import { SaveDashboardAsButton, SaveDashboardButton } from '../SaveDashboard/SaveDashboardButton';
 import { VariableEditorContainer } from '../../../variables/editor/VariableEditorContainer';
 import { DashboardPermissions } from '../DashboardPermissions/DashboardPermissions';
 import { GeneralSettings } from './GeneralSettings';
@@ -15,7 +15,7 @@ import { LinksSettings } from './LinksSettings';
 import { VersionsSettings } from './VersionsSettings';
 import { JsonEditorSettings } from './JsonEditorSettings';
 import { GrafanaTheme2, locationUtil } from '@grafana/data';
-import { locationService } from '@grafana/runtime';
+import { locationService, reportInteraction } from '@grafana/runtime';
 
 export interface Props {
   dashboard: DashboardModel;
@@ -138,7 +138,10 @@ export function DashboardSettings({ dashboard, editview }: Props) {
             <aside className="dashboard-settings__aside">
               {pages.map((page) => (
                 <Link
-                  to={(loc) => locationUtil.updateSearchParams(loc.search, `editview=${page.id}`)}
+                  to={(loc) => {
+                    reportInteraction(`Dashboard settings navigation to ${page.id}`);
+                    return locationUtil.updateSearchParams(loc.search, `editview=${page.id}`);
+                  }}
                   className={cx('dashboard-settings__nav-item', { active: page.id === editview })}
                   key={page.id}
                 >
diff --git a/public/app/features/variables/editor/VariableEditorList.tsx b/public/app/features/variables/editor/VariableEditorList.tsx
index 44a17fb2b21..b6f27b4fe9c 100644
--- a/public/app/features/variables/editor/VariableEditorList.tsx
+++ b/public/app/features/variables/editor/VariableEditorList.tsx
@@ -1,6 +1,7 @@
 import React, { ReactElement } from 'react';
 import { DragDropContext, Droppable, DropResult } from 'react-beautiful-dnd';
 import { selectors } from '@grafana/e2e-selectors';
+import { reportInteraction } from '@grafana/runtime';
 
 import { VariableModel } from '../types';
 import { VariableIdentifier } from '../state/types';
@@ -33,6 +34,7 @@ export function VariableEditorList({
     if (!result.destination || !result.source) {
       return;
     }
+    reportInteraction('Variable drag and drop');
     const identifier = JSON.parse(result.draggableId);
     onChangeOrder(identifier, result.source.index, result.destination.index);
   };
diff --git a/public/app/features/variables/editor/VariableEditorListRow.tsx b/public/app/features/variables/editor/VariableEditorListRow.tsx
index f0572d6a0d7..6d117fdcd1a 100644
--- a/public/app/features/variables/editor/VariableEditorListRow.tsx
+++ b/public/app/features/variables/editor/VariableEditorListRow.tsx
@@ -4,6 +4,7 @@ import { Draggable } from 'react-beautiful-dnd';
 import { GrafanaTheme2 } from '@grafana/data';
 import { Icon, IconButton, useStyles2, useTheme2 } from '@grafana/ui';
 import { selectors } from '@grafana/e2e-selectors';
+import { reportInteraction } from '@grafana/runtime';
 
 import { getVariableUsages, UsagesToNetwork, VariableUsageTree } from '../inspect/utils';
 import { hasOptions, isAdHoc, isQuery } from '../guard';
@@ -84,6 +85,7 @@ export function VariableEditorListRow({
             <IconButton
               onClick={(event) => {
                 event.preventDefault();
+                reportInteraction('Duplicate variable');
                 propsOnDuplicate(identifier);
               }}
               name="copy"
@@ -96,6 +98,7 @@ export function VariableEditorListRow({
             <IconButton
               onClick={(event) => {
                 event.preventDefault();
+                reportInteraction('Delete variable');
                 propsOnDelete(identifier);
               }}
               name="trash-alt"
diff --git a/public/app/features/variables/inspect/VariableUsagesButton.tsx b/public/app/features/variables/inspect/VariableUsagesButton.tsx
index 50cfdb33ed7..1cc89513179 100644
--- a/public/app/features/variables/inspect/VariableUsagesButton.tsx
+++ b/public/app/features/variables/inspect/VariableUsagesButton.tsx
@@ -1,5 +1,6 @@
 import React, { FC, useMemo } from 'react';
 import { IconButton } from '@grafana/ui';
+import { reportInteraction } from '@grafana/runtime';
 
 import { UsagesToNetwork } from './utils';
 import { NetworkGraphModal } from './NetworkGraphModal';
@@ -26,7 +27,16 @@ export const VariableUsagesButton: FC<Props> = ({ id, usages, isAdhoc }) => {
   return (
     <NetworkGraphModal show={false} title={`Showing usages for: $${id}`} nodes={nodes} edges={network.edges}>
       {({ showModal }) => {
-        return <IconButton onClick={() => showModal()} name="code-branch" title="Show usages" />;
+        return (
+          <IconButton
+            onClick={() => {
+              reportInteraction('Show variable usages');
+              showModal();
+            }}
+            name="code-branch"
+            title="Show usages"
+          />
+        );
       }}
     </NetworkGraphModal>
   );
diff --git a/public/app/features/variables/inspect/VariablesDependenciesButton.tsx b/public/app/features/variables/inspect/VariablesDependenciesButton.tsx
index 1b3155e2469..142e6fcaca3 100644
--- a/public/app/features/variables/inspect/VariablesDependenciesButton.tsx
+++ b/public/app/features/variables/inspect/VariablesDependenciesButton.tsx
@@ -1,7 +1,8 @@
 import React, { FC, useMemo } from 'react';
 import { Provider } from 'react-redux';
-// @ts-ignore
 import { Button } from '@grafana/ui';
+import { reportInteraction } from '@grafana/runtime';
+
 import { createDependencyEdges, createDependencyNodes, filterNodesWithDependencies } from './utils';
 import { store } from '../../../store/store';
 import { VariableModel } from '../types';
@@ -34,7 +35,14 @@ export const UnProvidedVariablesDependenciesButton: FC<Props> = ({ variables })
     >
       {({ showModal }) => {
         return (
-          <Button onClick={() => showModal()} icon="channel-add" variant="secondary">
+          <Button
+            onClick={() => {
+              reportInteraction('Show variable dependencies');
+              showModal();
+            }}
+            icon="channel-add"
+            variant="secondary"
+          >
             Show dependencies
           </Button>
         );