From bb5aaa2dce70cb78487bc498ffe6de07cca93685 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Tue, 18 Sep 2018 23:18:39 +0200 Subject: [PATCH] pkg/services/sqlstore/alert_notification.go: Simplify err check $ gometalinter --vendor --disable=all --enable=megacheck --deadline=10m ./... pkg/services/sqlstore/alert_notification.go:242:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (megacheck) --- pkg/services/sqlstore/alert_notification.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pkg/services/sqlstore/alert_notification.go b/pkg/services/sqlstore/alert_notification.go index 19ed960638e..31867910ddb 100644 --- a/pkg/services/sqlstore/alert_notification.go +++ b/pkg/services/sqlstore/alert_notification.go @@ -239,11 +239,8 @@ func RecordNotificationJournal(ctx context.Context, cmd *m.RecordNotificationJou Success: cmd.Success, } - if _, err := sess.Insert(journalEntry); err != nil { - return err - } - - return nil + _, err := sess.Insert(journalEntry) + return err }) }