From bb94681d5a186982e49ce757097375db85bfb069 Mon Sep 17 00:00:00 2001
From: Connor Lindsey <cblindsey3@gmail.com>
Date: Wed, 1 Jun 2022 11:32:32 -0600
Subject: [PATCH] Tracing: Fix trace links in traces panel (#50028)

---
 .../src/TraceTimelineViewer/SpanLinks.tsx     | 45 +++++++++++--------
 1 file changed, 27 insertions(+), 18 deletions(-)

diff --git a/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanLinks.tsx b/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanLinks.tsx
index b477c6e33e1..36b224e16b5 100644
--- a/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanLinks.tsx
+++ b/packages/jaeger-ui-components/src/TraceTimelineViewer/SpanLinks.tsx
@@ -18,12 +18,15 @@ const renderMenuItems = (links: SpanLinks, styles: ReturnType<typeof getStyles>,
             <MenuItem
               key={i}
               label="Logs for this span"
-              onClick={(e) => {
-                if (link.onClick) {
-                  link.onClick(e);
-                }
-                closeMenu();
-              }}
+              onClick={
+                link.onClick
+                  ? (event) => {
+                      event?.preventDefault();
+                      link.onClick!(event);
+                      closeMenu();
+                    }
+                  : undefined
+              }
               url={link.href}
               className={styles.menuItem}
             />
@@ -36,12 +39,15 @@ const renderMenuItems = (links: SpanLinks, styles: ReturnType<typeof getStyles>,
             <MenuItem
               key={i}
               label={link.title ?? 'Metrics for this span'}
-              onClick={(e) => {
-                if (link.onClick) {
-                  link.onClick(e);
-                }
-                closeMenu();
-              }}
+              onClick={
+                link.onClick
+                  ? (event) => {
+                      event?.preventDefault();
+                      link.onClick!(event);
+                      closeMenu();
+                    }
+                  : undefined
+              }
               url={link.href}
               className={styles.menuItem}
             />
@@ -54,12 +60,15 @@ const renderMenuItems = (links: SpanLinks, styles: ReturnType<typeof getStyles>,
             <MenuItem
               key={i}
               label={link.title ?? 'View linked span'}
-              onClick={(e) => {
-                if (link.onClick) {
-                  link.onClick(e);
-                }
-                closeMenu();
-              }}
+              onClick={
+                link.onClick
+                  ? (event) => {
+                      event?.preventDefault();
+                      link.onClick!(event);
+                      closeMenu();
+                    }
+                  : undefined
+              }
               url={link.href}
               className={styles.menuItem}
             />